[GitHub] [rocketmq-client-go] cserwen opened a new pull request, #1052: [ISSUE #1051 ] Close the channel before sending data if the consumer has been shutdown.

["cserwen (via GitHub)" <gi...@apache.org>]

cserwen opened a new pull request, #1052:
URL: https://github.com/apache/rocketmq-client-go/pull/1052

   
   ## What is the purpose of the change
   
   Fix #1051 
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] 0daypwn commented on pull request #1052: [ISSUE #1051 ] Close the channel before sending data if the consumer has been shutdown.

["0daypwn (via GitHub)" <gi...@apache.org>]

0daypwn commented on PR #1052:
URL: https://github.com/apache/rocketmq-client-go/pull/1052#issuecomment-1738724280

   https://github.com/apache/rocketmq-client-go/blob/da20ee7b0743a08ecf1fc53403f530b74eea2257/consumer/consumer.go#L296-L306
   谁写入channel，谁负责关闭 是个好习惯
   
   在已经有 close(pq.closeChan) 之后，再 close(pq.msgCh) 这个操作完全是多余的，关闭还会导致上述写入的风险。
   在 close(pq.closeChan) 之后，只要不 close(pq.msgCh)， pq.putMessage 和 pq.getMessage 即使select到 msgCh 也不会有影响。 pq.putMessage 和 pq.getMessage  之后是一定可以return的。
   因此我认为可以只去掉 close(pq.msgCh) 这部分即可 @cserwen 
   
   
   另外 consumer/consumer.go 这部分是基类
   修改需要考虑 
   consumer/push_consumer.go
   consuemr/pull_consumer.go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org