You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/07/28 14:39:16 UTC
Re: Review Request 36847: WIP: Added HTTP Delete Method.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/
-----------------------------------------------------------
(Updated July 28, 2015, 12:39 p.m.)
Review request for mesos and Alexander Rukletsov.
Summary (updated)
-----------------
WIP: Added HTTP Delete Method.
Bugs: MESOS-3152
https://issues.apache.org/jira/browse/MESOS-3152
Repository: mesos
Description
-------
Added HTTP Delete Method.
Diffs
-----
3rdparty/libprocess/include/process/http.hpp 9faed55247a3ccd629db7b85dbf31d3117e120e9
3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445
Diff: https://reviews.apache.org/r/36847/diff/
Testing (updated)
-------
make check
==== THIS IS WIP ====
Thanks,
Joerg Schad
Re: Review Request 36847: WIP: Added HTTP Delete Method.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review93299
-----------------------------------------------------------
Bad patch!
Reviews applied: [36847]
Failed command: ./support/apply-review.sh -n -r 36847
Error:
2015-07-28 14:59:16 URL:https://reviews.apache.org/r/36847/diff/raw/ [4071/4071] -> "36847.patch" [1]
Successfully applied: WIP: Added HTTP Delete Method.
Added HTTP Delete Method.
Review: https://reviews.apache.org/r/36847
Checking 3 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.
Please use separate commits for mesos, libprocess and stout.
Paths grouped by project:
mesos:
docs/oversubscription.md
libprocess:
3rdparty/libprocess/include/process/http.hpp
3rdparty/libprocess/src/http.cpp
3rdparty/libprocess/src/tests/http_tests.cpp
Failed to commit patch
- Mesos ReviewBot
On July 28, 2015, 1:13 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36847/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 1:13 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-3152
> https://issues.apache.org/jira/browse/MESOS-3152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added HTTP Delete Method.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 9faed55247a3ccd629db7b85dbf31d3117e120e9
> 3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
> 3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445
> docs/oversubscription.md b1a6c9979025ce33190792a07b8e9618c518430e
>
> Diff: https://reviews.apache.org/r/36847/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36847: Added HTTP Delete Method.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review93326
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36847]
All tests passed.
- Mesos ReviewBot
On July 28, 2015, 4:45 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36847/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 4:45 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-3152
> https://issues.apache.org/jira/browse/MESOS-3152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 9faed55247a3ccd629db7b85dbf31d3117e120e9
> 3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
> 3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445
>
> Diff: https://reviews.apache.org/r/36847/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36847: Added HTTP Delete Method.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/
-----------------------------------------------------------
(Updated July 28, 2015, 4:45 p.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-3152
https://issues.apache.org/jira/browse/MESOS-3152
Repository: mesos
Description (updated)
-------
see summary.
Diffs
-----
3rdparty/libprocess/include/process/http.hpp 9faed55247a3ccd629db7b85dbf31d3117e120e9
3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445
Diff: https://reviews.apache.org/r/36847/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 36847: Added HTTP Delete Method.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review93307
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On July 28, 2015, 4:26 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36847/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 4:26 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-3152
> https://issues.apache.org/jira/browse/MESOS-3152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added HTTP Delete Method.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 9faed55247a3ccd629db7b85dbf31d3117e120e9
> 3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
> 3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445
>
> Diff: https://reviews.apache.org/r/36847/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36847: Added HTTP Delete Method.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/
-----------------------------------------------------------
(Updated July 28, 2015, 4:26 p.m.)
Review request for mesos and Alexander Rukletsov.
Summary (updated)
-----------------
Added HTTP Delete Method.
Bugs: MESOS-3152
https://issues.apache.org/jira/browse/MESOS-3152
Repository: mesos
Description
-------
Added HTTP Delete Method.
Diffs
-----
3rdparty/libprocess/include/process/http.hpp 9faed55247a3ccd629db7b85dbf31d3117e120e9
3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445
Diff: https://reviews.apache.org/r/36847/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 36847: WIP: Added HTTP Delete Method.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/
-----------------------------------------------------------
(Updated July 28, 2015, 4:14 p.m.)
Review request for mesos and Alexander Rukletsov.
Changes
-------
Rebased
Bugs: MESOS-3152
https://issues.apache.org/jira/browse/MESOS-3152
Repository: mesos
Description
-------
Added HTTP Delete Method.
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp 9faed55247a3ccd629db7b85dbf31d3117e120e9
3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445
Diff: https://reviews.apache.org/r/36847/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 36847: WIP: Added HTTP Delete Method.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/
-----------------------------------------------------------
(Updated July 28, 2015, 1:13 p.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-3152
https://issues.apache.org/jira/browse/MESOS-3152
Repository: mesos
Description
-------
Added HTTP Delete Method.
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp 9faed55247a3ccd629db7b85dbf31d3117e120e9
3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
3rdparty/libprocess/src/tests/http_tests.cpp 01f243cd9c46e162c16e9bb452a846faf31d1445
docs/oversubscription.md b1a6c9979025ce33190792a07b8e9618c518430e
Diff: https://reviews.apache.org/r/36847/diff/
Testing (updated)
-------
make check
Thanks,
Joerg Schad