You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Balaji Varadarajan (Jira)" <ji...@apache.org> on 2019/10/16 07:50:00 UTC
[jira] [Commented] (HUDI-304) Bring back spotless plugin
[ https://issues.apache.org/jira/browse/HUDI-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952585#comment-16952585 ]
Balaji Varadarajan commented on HUDI-304:
-----------------------------------------
[~leesf] : FYI As part of [https://github.com/apache/incubator-hudi/pull/953] spotcheck is disabled.
> Bring back spotless plugin
> ---------------------------
>
> Key: HUDI-304
> URL: https://issues.apache.org/jira/browse/HUDI-304
> Project: Apache Hudi (incubating)
> Issue Type: Task
> Components: Developer Productivity
> Reporter: Balaji Varadarajan
> Priority: Major
>
> spotless plugin has been turned off as the eclipse style format it was referencing was removed due to compliance reasons.
> We use google style eclipse format with some changes
> 90c90
> < <setting id="org.eclipse.jdt.core.formatter.lineSplit" value="100"/>
> ---
> > <setting id="org.eclipse.jdt.core.formatter.lineSplit" value="120"/>
> 242c242
> < <setting id="org.eclipse.jdt.core.formatter.comment.line_length" value="100"/>
> ---
> > <setting id="org.eclipse.jdt.core.formatter.comment.line_length" value="120"/>
>
> The eclipse style sheet was originally obtained from [https://github.com/google/styleguide] which CC -By 3.0 license which is not compatible for source distribution (See [https://www.apache.org/legal/resolved.html#cc-by])
>
> We need to figure out a way to bring this back
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)