[jira] [Commented] (PROTON-1128) [C++ binding] Symbol exports use wrong directive for proton::condition

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132831#comment-15132831 ] 

ASF subversion and git services commented on PROTON-1128:
---------------------------------------------------------

Commit 4ea3d26257ff5f707dfd7b44214ad22857d7b364 in qpid-proton's branch refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=4ea3d26 ]

PROTON-1128: [C++ binding] Fix incorrect symbol export declaration.


> [C++ binding] Symbol exports use wrong directive for proton::condition
> ----------------------------------------------------------------------
>
>                 Key: PROTON-1128
>                 URL: https://issues.apache.org/jira/browse/PROTON-1128
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: cpp-binding
>    Affects Versions: 0.12.0
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
>            Priority: Minor
>
> The C++ binding API header file incorrectly uses PN_CPP_EXPORT rather than PN_CPP_EXTERN.
> In theory on Windows (the only system where these directives are currently active) this could mean that user programs using the proton::condition API would be unable to do so as the program would be exporting the API rather than importing it.
> However in limited tests using VS 2015 it doesn't seem to actually be causing a problem.
> It may be that it is problematic in other (earlier) VS compilers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)