[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #421: Add friendly names to catalog tables

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #421: Add friendly names to catalog tables
URL: https://github.com/apache/incubator-iceberg/pull/421#discussion_r318396277
 
 

 ##########
 File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
 ##########
 @@ -43,6 +43,11 @@ public HiveCatalog(Configuration conf) {
     this.conf = conf;
   }
 
+  @Override
+  protected String name() {
+    return conf.get("hive.metastore.uris");
 
 Review comment:
   This is usually a collection of uris. So I think the catalogName would come out as `thrift://host1:port1/,thrift://host2:port2/` .  I don' think its a big deal. Just calling it out

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org