[GitHub] [spark] cloud-fan commented on a change in pull request #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27902: [SPARK-31147][SQL] forbid CHAR/VARCHAR type in non-Hive tables
URL: https://github.com/apache/spark/pull/27902#discussion_r395439533
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
 ##########
 @@ -329,4 +330,18 @@ private[sql] object CatalogV2Util {
       .getOrElse(catalogManager.v2SessionCatalog)
       .asTableCatalog
   }
+
+  def failCharType(dt: DataType): Unit = {
+    if (HiveStringType.containsCharType(dt)) {
 
 Review comment:
   Yea, will update it today.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org