You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/11/07 14:19:40 UTC
Review Request 63621: Added a devolve function for
'OfferOperationStatus'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63621/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jie Yu.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/internal/devolve.hpp 48d9c33fff376f7842f9b72bf84056482cefadcd
src/internal/devolve.cpp e05fcd4d0f423a2ba13bdcf6ba6561b43e31977d
Diff: https://reviews.apache.org/r/63621/diff/1/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 63621: Added a devolve function for
'OfferOperationStatus'.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63621/
-----------------------------------------------------------
(Updated Nov. 8, 2017, 4:22 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Addressed issues.
Repository: mesos
Description (updated)
-------
Added a devolve function for 'OfferOperationStatus'.
Diffs (updated)
-----
src/internal/devolve.hpp 48d9c33fff376f7842f9b72bf84056482cefadcd
src/internal/devolve.cpp e05fcd4d0f423a2ba13bdcf6ba6561b43e31977d
Diff: https://reviews.apache.org/r/63621/diff/2/
Changes: https://reviews.apache.org/r/63621/diff/1-2/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 63621: Added a devolve function for
'OfferOperationStatus'.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63621/#review190311
-----------------------------------------------------------
Fix it, then Ship it!
src/internal/devolve.hpp
Lines 70 (patched)
<https://reviews.apache.org/r/63621/#comment267600>
Let's put this right after `devolve(const v1::Offer&)`.
src/internal/devolve.cpp
Lines 163-166 (patched)
<https://reviews.apache.org/r/63621/#comment267601>
Let's put this right behind `devolve(const v1::Offer&)`'s implementation.
- Benjamin Bannier
On Nov. 7, 2017, 3:19 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63621/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 3:19 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/internal/devolve.hpp 48d9c33fff376f7842f9b72bf84056482cefadcd
> src/internal/devolve.cpp e05fcd4d0f423a2ba13bdcf6ba6561b43e31977d
>
>
> Diff: https://reviews.apache.org/r/63621/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>