[GitHub] [spark] iRakson commented on a change in pull request #26779: [SPARK-30150][SQL]AddFile Command do not accept quoted path

[GitBox <gi...@apache.org>]

iRakson commented on a change in pull request #26779: [SPARK-30150][SQL]AddFile Command do not accept quoted path
URL: https://github.com/apache/spark/pull/26779#discussion_r355285095
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
 ##########
 @@ -357,7 +357,7 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder(conf) {
    * }}}
    */
   override def visitManageResource(ctx: ManageResourceContext): LogicalPlan = withOrigin(ctx) {
-    val mayebePaths = remainder(ctx.identifier).trim
+    val mayebePaths = pathWrapper(remainder(ctx.identifier).trim)
 
 Review comment:
   I changed the grammar to take string literal as well for ADD/LIST. 
   
   Now all of  `add file abc.txt`, `add file 'abc.txt'` and `add file "abc.txt"`  are supported.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org