[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

[GitBox <gi...@apache.org>]

lordgamez commented on a change in pull request #866:
URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468388881



##########
File path: extensions/libarchive/MergeContent.cpp
##########
@@ -140,6 +146,10 @@ void MergeContent::onSchedule(core::ProcessContext *context, core::ProcessSessio
   if (context->getProperty(KeepPath.getName(), value) && !value.empty()) {
     org::apache::nifi::minifi::utils::StringUtils::StringToBool(value, keepPath_);
   }
+  value = "";
+  if (context->getProperty(AttributeStrategy.getName(), value) && !value.empty()) {
+      this->attributeStrategy_ = value;

Review comment:
       I think having the `this` keyword is just redundant here if we have the `_` suffix for member variables, and as resetting the `value` has no reason in this case I can just remove them in all occurrences and keep the consistency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org