You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "GanfengTan (via GitHub)" <gi...@apache.org> on 2023/05/16 04:32:29 UTC

[GitHub] [inlong] GanfengTan opened a new pull request, #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

GanfengTan opened a new pull request, #8032:
URL: https://github.com/apache/inlong/pull/8032

   Support to dynamically select flink version packaging.
   
   1. The packaging of different versions does not conflict with each other, and the dependent versions are managed by themselves.
   2. The dependencies related to flink under the Sort module only need to introduce sort-flink-dependencies-xxx.
   3. To switch the Flink version under the Sort module, you need to modify the relevant conflicts to ensure compatibility. Looking forward to your PR.
   4. How to switch Flink version?
   - By default, it will only pack: profile id is v1.13
   - If you need to package all modules: mvn clean install -DskipTests -P v1.15,v1.13
   
   - Fixes #8031 
   
   ### Motivation
   
   
   ### Modifications
   
   
   ### Verifying this change
   
   *(Please pick either of the following options)*
   
   - [x] This change is a trivial rework/code cleanup without any test coverage.
   
   - [ ] This change is already covered by existing tests, such as:
     *(please describe tests)*
   
   - [ ] This change added tests and can be verified as follows:
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] GanfengTan commented on a diff in pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on code in PR #8032:
URL: https://github.com/apache/inlong/pull/8032#discussion_r1194835765


##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-flink-dependencies-v1.13/pom.xml:
##########
@@ -0,0 +1,60 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review Comment:
   This needs to add a version, switch the core dependency or there is no way to distinguish.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] EMsnap commented on a diff in pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #8032:
URL: https://github.com/apache/inlong/pull/8032#discussion_r1194723944


##########
inlong-sort/sort-flink/sort-flink-v1.13/pom.xml:
##########
@@ -32,8 +32,193 @@
 
     <modules>
         <module>sort-connectors-v1.13</module>
+        <module>sort-flink-dependencies-v1.13</module>
     </modules>
 
-    <properties />
+    <properties>
+        <flink.version>1.13.5</flink.version>
+        <flink.connector.mongodb.cdc.version>2.3.0</flink.connector.mongodb.cdc.version>
+        <flink.connector.redis>1.1.0</flink.connector.redis>
+        <flink.scala.binary.version>2.11</flink.scala.binary.version>
+        <flink.connector.mysql.cdc.version>2.2.1</flink.connector.mysql.cdc.version>
+        <flink.scala.binary.version>2.11</flink.scala.binary.version>
+        <flink.jackson.version>2.12.1-13.0</flink.jackson.version>
+        <flink.connector.postgres.cdc.version>2.2.1</flink.connector.postgres.cdc.version>
+        <flink.connector.sqlserver.cdc.version>2.2.1</flink.connector.sqlserver.cdc.version>
+        <flink.pulsar.version>1.13.6.2</flink.pulsar.version>
+        <flink.protobuf.version>2.7.6</flink.protobuf.version>
+        <flink.connector.oracle.cdc.version>2.3.0</flink.connector.oracle.cdc.version>
+        <flink.connector.doris.version>1.0.3</flink.connector.doris.version>
 

Review Comment:
   extra blank here 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] EMsnap commented on a diff in pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #8032:
URL: https://github.com/apache/inlong/pull/8032#discussion_r1194730607


##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-flink-dependencies-v1.13/pom.xml:
##########
@@ -0,0 +1,60 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review Comment:
   duplicate version v1.13 since the directory name contains flink version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] gong commented on a diff in pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on code in PR #8032:
URL: https://github.com/apache/inlong/pull/8032#discussion_r1196294623


##########
inlong-sort/sort-flink/sort-flink-v1.15/pom.xml:
##########
@@ -0,0 +1,228 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>org.apache.inlong</groupId>
+        <artifactId>sort-flink</artifactId>
+        <version>1.8.0-SNAPSHOT</version>
+    </parent>
+
+    <artifactId>sort-flink-v1.15</artifactId>
+    <packaging>pom</packaging>
+    <name>Apache InLong - Sort Flink v1.15</name>
+
+    <modules>
+        <module>sort-connectors-v1.15</module>
+        <module>sort-flink-dependencies-v1.15</module>
+    </modules>
+
+    <properties>
+        <flink.version>1.15.4</flink.version>
+        <debezium.version>2.0.1.Final</debezium.version>
+        <flink.connector.mongodb.cdc.version>2.3.0</flink.connector.mongodb.cdc.version>
+        <flink.connector.oracle.cdc.version>2.3.0</flink.connector.oracle.cdc.version>
+        <flink.connector.mysql.cdc.version>2.3.0</flink.connector.mysql.cdc.version>
+        <flink.connector.postgres.cdc.version>2.3.0</flink.connector.postgres.cdc.version>
+        <flink.connector.sqlserver.cdc.version>2.3.0</flink.connector.sqlserver.cdc.version>
+        <flink.pulsar.version>1.13.6.2</flink.pulsar.version>
+        <flink.connector.doris.version>1.0.3</flink.connector.doris.version>
+        <flink.connector.redis>1.1.0</flink.connector.redis>
+        <flink.scala.binary.version>2.12</flink.scala.binary.version>
+        <flink.jackson.version>2.12.1-13.0</flink.jackson.version>
+        <flink.protobuf.version>2.7.6</flink.protobuf.version>
+
+        <sqlserver.jdbc.version>7.2.2.jre8</sqlserver.jdbc.version>
+
+        <hudi.version>0.12.1</hudi.version>
+
+        <thrift.version>0.9.3</thrift.version>
+
+    </properties>
+
+    <dependencyManagement>
+        <dependencies>
+            <!-- flink connector-->
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-kafka</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-hive_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-hbase-2.2</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-postgres-cdc</artifactId>
+                <version>${flink.connector.postgres.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-oracle-cdc</artifactId>
+                <version>${flink.connector.oracle.cdc.version}</version>
+                <!-- ojdbc8 is FUTC license and needs to be excluded -->
+                <exclusions>
+                    <exclusion>
+                        <groupId>com.oracle.ojdbc</groupId>
+                        <artifactId>ojdbc8</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-sqlserver-cdc</artifactId>
+                <version>${flink.connector.sqlserver.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-mysql-cdc</artifactId>
+                <version>${flink.connector.mysql.cdc.version}</version>
+                <!-- mysql-connector-java is LGPL license and needs to be excluded -->
+                <exclusions>
+                    <exclusion>
+                        <groupId>mysql</groupId>
+                        <artifactId>mysql-connector-java</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-jdbc</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.streamnative.connectors</groupId>
+                <artifactId>pulsar-flink-connector-origin</artifactId>
+                <version>${flink.pulsar.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-mongodb-cdc</artifactId>
+                <version>${flink.connector.mongodb.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.bahir</groupId>
+                <artifactId>flink-connector-redis_${flink.scala.binary.version}</artifactId>
+                <version>${flink.connector.redis}</version>
+            </dependency>
+            <!-- hudi -->
+            <dependency>
+                <groupId>org.apache.hudi</groupId>
+                <artifactId>hudi-flink1.13-bundle</artifactId>
+                <version>${hudi.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.streamnative.connectors</groupId>
+                <artifactId>flink-protobuf</artifactId>
+                <version>${flink.protobuf.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.microsoft.sqlserver</groupId>
+                <artifactId>mssql-jdbc</artifactId>
+                <version>${sqlserver.jdbc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.iceberg</groupId>
+                <artifactId>iceberg-flink-runtime-1.14</artifactId>
+                <version>${iceberg.version}</version>
+            </dependency>
+
+            <!-- flink -->
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-api-java-bridge</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-runtime</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-clients</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-planner_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+                <scope>test</scope>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-streaming-java</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-streaming-scala_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+            </dependency>

Review Comment:
   @GanfengTan I see, I missed  a pom file because of too many dir.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] GanfengTan commented on a diff in pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on code in PR #8032:
URL: https://github.com/apache/inlong/pull/8032#discussion_r1195004671


##########
inlong-sort/sort-flink/sort-flink-v1.15/pom.xml:
##########
@@ -0,0 +1,228 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>org.apache.inlong</groupId>
+        <artifactId>sort-flink</artifactId>
+        <version>1.8.0-SNAPSHOT</version>
+    </parent>
+
+    <artifactId>sort-flink-v1.15</artifactId>
+    <packaging>pom</packaging>
+    <name>Apache InLong - Sort Flink v1.15</name>
+
+    <modules>
+        <module>sort-connectors-v1.15</module>
+        <module>sort-flink-dependencies-v1.15</module>
+    </modules>
+
+    <properties>
+        <flink.version>1.15.4</flink.version>
+        <debezium.version>2.0.1.Final</debezium.version>
+        <flink.connector.mongodb.cdc.version>2.3.0</flink.connector.mongodb.cdc.version>
+        <flink.connector.oracle.cdc.version>2.3.0</flink.connector.oracle.cdc.version>
+        <flink.connector.mysql.cdc.version>2.3.0</flink.connector.mysql.cdc.version>
+        <flink.connector.postgres.cdc.version>2.3.0</flink.connector.postgres.cdc.version>
+        <flink.connector.sqlserver.cdc.version>2.3.0</flink.connector.sqlserver.cdc.version>
+        <flink.pulsar.version>1.13.6.2</flink.pulsar.version>
+        <flink.connector.doris.version>1.0.3</flink.connector.doris.version>
+        <flink.connector.redis>1.1.0</flink.connector.redis>
+        <flink.scala.binary.version>2.12</flink.scala.binary.version>
+        <flink.jackson.version>2.12.1-13.0</flink.jackson.version>
+        <flink.protobuf.version>2.7.6</flink.protobuf.version>
+
+        <sqlserver.jdbc.version>7.2.2.jre8</sqlserver.jdbc.version>
+
+        <hudi.version>0.12.1</hudi.version>
+
+        <thrift.version>0.9.3</thrift.version>
+
+    </properties>
+
+    <dependencyManagement>
+        <dependencies>
+            <!-- flink connector-->
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-kafka</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-hive_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-hbase-2.2</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-postgres-cdc</artifactId>
+                <version>${flink.connector.postgres.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-oracle-cdc</artifactId>
+                <version>${flink.connector.oracle.cdc.version}</version>
+                <!-- ojdbc8 is FUTC license and needs to be excluded -->
+                <exclusions>
+                    <exclusion>
+                        <groupId>com.oracle.ojdbc</groupId>
+                        <artifactId>ojdbc8</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-sqlserver-cdc</artifactId>
+                <version>${flink.connector.sqlserver.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-mysql-cdc</artifactId>
+                <version>${flink.connector.mysql.cdc.version}</version>
+                <!-- mysql-connector-java is LGPL license and needs to be excluded -->
+                <exclusions>
+                    <exclusion>
+                        <groupId>mysql</groupId>
+                        <artifactId>mysql-connector-java</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-jdbc</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.streamnative.connectors</groupId>
+                <artifactId>pulsar-flink-connector-origin</artifactId>
+                <version>${flink.pulsar.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-mongodb-cdc</artifactId>
+                <version>${flink.connector.mongodb.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.bahir</groupId>
+                <artifactId>flink-connector-redis_${flink.scala.binary.version}</artifactId>
+                <version>${flink.connector.redis}</version>
+            </dependency>
+            <!-- hudi -->
+            <dependency>
+                <groupId>org.apache.hudi</groupId>
+                <artifactId>hudi-flink1.13-bundle</artifactId>
+                <version>${hudi.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.streamnative.connectors</groupId>
+                <artifactId>flink-protobuf</artifactId>
+                <version>${flink.protobuf.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.microsoft.sqlserver</groupId>
+                <artifactId>mssql-jdbc</artifactId>
+                <version>${sqlserver.jdbc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.iceberg</groupId>
+                <artifactId>iceberg-flink-runtime-1.14</artifactId>
+                <version>${iceberg.version}</version>
+            </dependency>
+
+            <!-- flink -->
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-api-java-bridge</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-runtime</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-clients</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-planner_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+                <scope>test</scope>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-streaming-java</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-streaming-scala_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+            </dependency>

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] dockerzhang merged pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #8032:
URL: https://github.com/apache/inlong/pull/8032


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] featzhang commented on a diff in pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang commented on code in PR #8032:
URL: https://github.com/apache/inlong/pull/8032#discussion_r1197286082


##########
inlong-sort/sort-end-to-end-tests/pom.xml:
##########
@@ -80,41 +80,27 @@
             </exclusions>
         </dependency>
         <dependency>
-            <groupId>org.apache.flink</groupId>
-            <artifactId>flink-core</artifactId>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.flink</groupId>
-            <artifactId>flink-runtime_${scala.binary.version}</artifactId>
-            <version>${flink.version}</version>
+            <groupId>org.apache.inlong</groupId>
+            <artifactId>sort-flink-dependencies-${sort.flink.version}</artifactId>
+            <version>${project.version}</version>
             <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.apache.flink</groupId>
-            <artifactId>flink-streaming-java_${flink.scala.binary.version}</artifactId>
+            <artifactId>flink-core</artifactId>
             <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.apache.flink</groupId>
-            <artifactId>flink-table-api-java-bridge_${flink.scala.binary.version}</artifactId>
+            <artifactId>flink-runtime_${scala.binary.version}</artifactId>
+            <version>${flink.version}</version>

Review Comment:
   Is it possible to use the same method as the version of flink-core to ensure that the version is consistent?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] GanfengTan commented on a diff in pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on code in PR #8032:
URL: https://github.com/apache/inlong/pull/8032#discussion_r1194833920


##########
inlong-sort/sort-flink/sort-flink-v1.13/pom.xml:
##########
@@ -32,8 +32,193 @@
 
     <modules>
         <module>sort-connectors-v1.13</module>
+        <module>sort-flink-dependencies-v1.13</module>
     </modules>
 
-    <properties />
+    <properties>
+        <flink.version>1.13.5</flink.version>
+        <flink.connector.mongodb.cdc.version>2.3.0</flink.connector.mongodb.cdc.version>
+        <flink.connector.redis>1.1.0</flink.connector.redis>
+        <flink.scala.binary.version>2.11</flink.scala.binary.version>
+        <flink.connector.mysql.cdc.version>2.2.1</flink.connector.mysql.cdc.version>
+        <flink.scala.binary.version>2.11</flink.scala.binary.version>
+        <flink.jackson.version>2.12.1-13.0</flink.jackson.version>
+        <flink.connector.postgres.cdc.version>2.2.1</flink.connector.postgres.cdc.version>
+        <flink.connector.sqlserver.cdc.version>2.2.1</flink.connector.sqlserver.cdc.version>
+        <flink.pulsar.version>1.13.6.2</flink.pulsar.version>
+        <flink.protobuf.version>2.7.6</flink.protobuf.version>
+        <flink.connector.oracle.cdc.version>2.3.0</flink.connector.oracle.cdc.version>
+        <flink.connector.doris.version>1.0.3</flink.connector.doris.version>
 

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] featzhang commented on pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang commented on PR #8032:
URL: https://github.com/apache/inlong/pull/8032#issuecomment-1552542340

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] EMsnap commented on pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on PR #8032:
URL: https://github.com/apache/inlong/pull/8032#issuecomment-1550620599

   I tested some connector in flink1.13 works fine in flink1.15, how do we manage in this situation ?  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] GanfengTan commented on a diff in pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on code in PR #8032:
URL: https://github.com/apache/inlong/pull/8032#discussion_r1196210888


##########
inlong-sort/sort-flink/sort-flink-v1.15/pom.xml:
##########
@@ -0,0 +1,228 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>org.apache.inlong</groupId>
+        <artifactId>sort-flink</artifactId>
+        <version>1.8.0-SNAPSHOT</version>
+    </parent>
+
+    <artifactId>sort-flink-v1.15</artifactId>
+    <packaging>pom</packaging>
+    <name>Apache InLong - Sort Flink v1.15</name>
+
+    <modules>
+        <module>sort-connectors-v1.15</module>
+        <module>sort-flink-dependencies-v1.15</module>
+    </modules>
+
+    <properties>
+        <flink.version>1.15.4</flink.version>
+        <debezium.version>2.0.1.Final</debezium.version>
+        <flink.connector.mongodb.cdc.version>2.3.0</flink.connector.mongodb.cdc.version>
+        <flink.connector.oracle.cdc.version>2.3.0</flink.connector.oracle.cdc.version>
+        <flink.connector.mysql.cdc.version>2.3.0</flink.connector.mysql.cdc.version>
+        <flink.connector.postgres.cdc.version>2.3.0</flink.connector.postgres.cdc.version>
+        <flink.connector.sqlserver.cdc.version>2.3.0</flink.connector.sqlserver.cdc.version>
+        <flink.pulsar.version>1.13.6.2</flink.pulsar.version>
+        <flink.connector.doris.version>1.0.3</flink.connector.doris.version>
+        <flink.connector.redis>1.1.0</flink.connector.redis>
+        <flink.scala.binary.version>2.12</flink.scala.binary.version>
+        <flink.jackson.version>2.12.1-13.0</flink.jackson.version>
+        <flink.protobuf.version>2.7.6</flink.protobuf.version>
+
+        <sqlserver.jdbc.version>7.2.2.jre8</sqlserver.jdbc.version>
+
+        <hudi.version>0.12.1</hudi.version>
+
+        <thrift.version>0.9.3</thrift.version>
+
+    </properties>
+
+    <dependencyManagement>
+        <dependencies>
+            <!-- flink connector-->
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-kafka</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-hive_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-hbase-2.2</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-postgres-cdc</artifactId>
+                <version>${flink.connector.postgres.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-oracle-cdc</artifactId>
+                <version>${flink.connector.oracle.cdc.version}</version>
+                <!-- ojdbc8 is FUTC license and needs to be excluded -->
+                <exclusions>
+                    <exclusion>
+                        <groupId>com.oracle.ojdbc</groupId>
+                        <artifactId>ojdbc8</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-sqlserver-cdc</artifactId>
+                <version>${flink.connector.sqlserver.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-mysql-cdc</artifactId>
+                <version>${flink.connector.mysql.cdc.version}</version>
+                <!-- mysql-connector-java is LGPL license and needs to be excluded -->
+                <exclusions>
+                    <exclusion>
+                        <groupId>mysql</groupId>
+                        <artifactId>mysql-connector-java</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-jdbc</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.streamnative.connectors</groupId>
+                <artifactId>pulsar-flink-connector-origin</artifactId>
+                <version>${flink.pulsar.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-mongodb-cdc</artifactId>
+                <version>${flink.connector.mongodb.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.bahir</groupId>
+                <artifactId>flink-connector-redis_${flink.scala.binary.version}</artifactId>
+                <version>${flink.connector.redis}</version>
+            </dependency>
+            <!-- hudi -->
+            <dependency>
+                <groupId>org.apache.hudi</groupId>
+                <artifactId>hudi-flink1.13-bundle</artifactId>
+                <version>${hudi.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.streamnative.connectors</groupId>
+                <artifactId>flink-protobuf</artifactId>
+                <version>${flink.protobuf.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.microsoft.sqlserver</groupId>
+                <artifactId>mssql-jdbc</artifactId>
+                <version>${sqlserver.jdbc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.iceberg</groupId>
+                <artifactId>iceberg-flink-runtime-1.14</artifactId>
+                <version>${iceberg.version}</version>
+            </dependency>
+
+            <!-- flink -->
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-api-java-bridge</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-runtime</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-clients</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-planner_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+                <scope>test</scope>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-streaming-java</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-streaming-scala_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+            </dependency>

Review Comment:
   <img width="776" alt="image" src="https://github.com/apache/inlong/assets/17596132/374afc0f-8d03-4249-97e6-63f144fadb17">
   Dependency transitive relationship.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] gong commented on a diff in pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on code in PR #8032:
URL: https://github.com/apache/inlong/pull/8032#discussion_r1194738955


##########
inlong-sort/sort-flink/sort-flink-v1.15/pom.xml:
##########
@@ -0,0 +1,228 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>org.apache.inlong</groupId>
+        <artifactId>sort-flink</artifactId>
+        <version>1.8.0-SNAPSHOT</version>
+    </parent>
+
+    <artifactId>sort-flink-v1.15</artifactId>
+    <packaging>pom</packaging>
+    <name>Apache InLong - Sort Flink v1.15</name>
+
+    <modules>
+        <module>sort-connectors-v1.15</module>
+        <module>sort-flink-dependencies-v1.15</module>
+    </modules>
+
+    <properties>
+        <flink.version>1.15.4</flink.version>
+        <debezium.version>2.0.1.Final</debezium.version>
+        <flink.connector.mongodb.cdc.version>2.3.0</flink.connector.mongodb.cdc.version>
+        <flink.connector.oracle.cdc.version>2.3.0</flink.connector.oracle.cdc.version>
+        <flink.connector.mysql.cdc.version>2.3.0</flink.connector.mysql.cdc.version>
+        <flink.connector.postgres.cdc.version>2.3.0</flink.connector.postgres.cdc.version>
+        <flink.connector.sqlserver.cdc.version>2.3.0</flink.connector.sqlserver.cdc.version>
+        <flink.pulsar.version>1.13.6.2</flink.pulsar.version>
+        <flink.connector.doris.version>1.0.3</flink.connector.doris.version>
+        <flink.connector.redis>1.1.0</flink.connector.redis>
+        <flink.scala.binary.version>2.12</flink.scala.binary.version>
+        <flink.jackson.version>2.12.1-13.0</flink.jackson.version>
+        <flink.protobuf.version>2.7.6</flink.protobuf.version>
+
+        <sqlserver.jdbc.version>7.2.2.jre8</sqlserver.jdbc.version>
+
+        <hudi.version>0.12.1</hudi.version>
+
+        <thrift.version>0.9.3</thrift.version>
+
+    </properties>
+
+    <dependencyManagement>
+        <dependencies>
+            <!-- flink connector-->
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-kafka</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-hive_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-hbase-2.2</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-postgres-cdc</artifactId>
+                <version>${flink.connector.postgres.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-oracle-cdc</artifactId>
+                <version>${flink.connector.oracle.cdc.version}</version>
+                <!-- ojdbc8 is FUTC license and needs to be excluded -->
+                <exclusions>
+                    <exclusion>
+                        <groupId>com.oracle.ojdbc</groupId>
+                        <artifactId>ojdbc8</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-sqlserver-cdc</artifactId>
+                <version>${flink.connector.sqlserver.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-mysql-cdc</artifactId>
+                <version>${flink.connector.mysql.cdc.version}</version>
+                <!-- mysql-connector-java is LGPL license and needs to be excluded -->
+                <exclusions>
+                    <exclusion>
+                        <groupId>mysql</groupId>
+                        <artifactId>mysql-connector-java</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-jdbc</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.streamnative.connectors</groupId>
+                <artifactId>pulsar-flink-connector-origin</artifactId>
+                <version>${flink.pulsar.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-mongodb-cdc</artifactId>
+                <version>${flink.connector.mongodb.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.bahir</groupId>
+                <artifactId>flink-connector-redis_${flink.scala.binary.version}</artifactId>
+                <version>${flink.connector.redis}</version>
+            </dependency>
+            <!-- hudi -->
+            <dependency>
+                <groupId>org.apache.hudi</groupId>
+                <artifactId>hudi-flink1.13-bundle</artifactId>
+                <version>${hudi.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.streamnative.connectors</groupId>
+                <artifactId>flink-protobuf</artifactId>
+                <version>${flink.protobuf.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.microsoft.sqlserver</groupId>
+                <artifactId>mssql-jdbc</artifactId>
+                <version>${sqlserver.jdbc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.iceberg</groupId>
+                <artifactId>iceberg-flink-runtime-1.14</artifactId>
+                <version>${iceberg.version}</version>
+            </dependency>
+
+            <!-- flink -->
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-api-java-bridge</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-runtime</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-clients</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-planner_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+                <scope>test</scope>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-streaming-java</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-streaming-scala_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+            </dependency>

Review Comment:
   flink core code scope should be provided



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] GanfengTan commented on a diff in pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on code in PR #8032:
URL: https://github.com/apache/inlong/pull/8032#discussion_r1197306791


##########
inlong-sort/sort-end-to-end-tests/pom.xml:
##########
@@ -80,41 +80,27 @@
             </exclusions>
         </dependency>
         <dependency>
-            <groupId>org.apache.flink</groupId>
-            <artifactId>flink-core</artifactId>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.flink</groupId>
-            <artifactId>flink-runtime_${scala.binary.version}</artifactId>
-            <version>${flink.version}</version>
+            <groupId>org.apache.inlong</groupId>
+            <artifactId>sort-flink-dependencies-${sort.flink.version}</artifactId>
+            <version>${project.version}</version>
             <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.apache.flink</groupId>
-            <artifactId>flink-streaming-java_${flink.scala.binary.version}</artifactId>
+            <artifactId>flink-core</artifactId>
             <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.apache.flink</groupId>
-            <artifactId>flink-table-api-java-bridge_${flink.scala.binary.version}</artifactId>
+            <artifactId>flink-runtime_${scala.binary.version}</artifactId>
+            <version>${flink.version}</version>

Review Comment:
   
   This place has been considered, just modify the root POM, and the dependencies of the flink environment have been handed over to a unified dependency module for management.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] gong commented on a diff in pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on code in PR #8032:
URL: https://github.com/apache/inlong/pull/8032#discussion_r1195886914


##########
inlong-sort/sort-flink/sort-flink-v1.15/pom.xml:
##########
@@ -0,0 +1,228 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>org.apache.inlong</groupId>
+        <artifactId>sort-flink</artifactId>
+        <version>1.8.0-SNAPSHOT</version>
+    </parent>
+
+    <artifactId>sort-flink-v1.15</artifactId>
+    <packaging>pom</packaging>
+    <name>Apache InLong - Sort Flink v1.15</name>
+
+    <modules>
+        <module>sort-connectors-v1.15</module>
+        <module>sort-flink-dependencies-v1.15</module>
+    </modules>
+
+    <properties>
+        <flink.version>1.15.4</flink.version>
+        <debezium.version>2.0.1.Final</debezium.version>
+        <flink.connector.mongodb.cdc.version>2.3.0</flink.connector.mongodb.cdc.version>
+        <flink.connector.oracle.cdc.version>2.3.0</flink.connector.oracle.cdc.version>
+        <flink.connector.mysql.cdc.version>2.3.0</flink.connector.mysql.cdc.version>
+        <flink.connector.postgres.cdc.version>2.3.0</flink.connector.postgres.cdc.version>
+        <flink.connector.sqlserver.cdc.version>2.3.0</flink.connector.sqlserver.cdc.version>
+        <flink.pulsar.version>1.13.6.2</flink.pulsar.version>
+        <flink.connector.doris.version>1.0.3</flink.connector.doris.version>
+        <flink.connector.redis>1.1.0</flink.connector.redis>
+        <flink.scala.binary.version>2.12</flink.scala.binary.version>
+        <flink.jackson.version>2.12.1-13.0</flink.jackson.version>
+        <flink.protobuf.version>2.7.6</flink.protobuf.version>
+
+        <sqlserver.jdbc.version>7.2.2.jre8</sqlserver.jdbc.version>
+
+        <hudi.version>0.12.1</hudi.version>
+
+        <thrift.version>0.9.3</thrift.version>
+
+    </properties>
+
+    <dependencyManagement>
+        <dependencies>
+            <!-- flink connector-->
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-kafka</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-hive_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-hbase-2.2</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-postgres-cdc</artifactId>
+                <version>${flink.connector.postgres.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-oracle-cdc</artifactId>
+                <version>${flink.connector.oracle.cdc.version}</version>
+                <!-- ojdbc8 is FUTC license and needs to be excluded -->
+                <exclusions>
+                    <exclusion>
+                        <groupId>com.oracle.ojdbc</groupId>
+                        <artifactId>ojdbc8</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-sqlserver-cdc</artifactId>
+                <version>${flink.connector.sqlserver.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-mysql-cdc</artifactId>
+                <version>${flink.connector.mysql.cdc.version}</version>
+                <!-- mysql-connector-java is LGPL license and needs to be excluded -->
+                <exclusions>
+                    <exclusion>
+                        <groupId>mysql</groupId>
+                        <artifactId>mysql-connector-java</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-connector-jdbc</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.streamnative.connectors</groupId>
+                <artifactId>pulsar-flink-connector-origin</artifactId>
+                <version>${flink.pulsar.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.ververica</groupId>
+                <artifactId>flink-connector-mongodb-cdc</artifactId>
+                <version>${flink.connector.mongodb.cdc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.bahir</groupId>
+                <artifactId>flink-connector-redis_${flink.scala.binary.version}</artifactId>
+                <version>${flink.connector.redis}</version>
+            </dependency>
+            <!-- hudi -->
+            <dependency>
+                <groupId>org.apache.hudi</groupId>
+                <artifactId>hudi-flink1.13-bundle</artifactId>
+                <version>${hudi.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>io.streamnative.connectors</groupId>
+                <artifactId>flink-protobuf</artifactId>
+                <version>${flink.protobuf.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>com.microsoft.sqlserver</groupId>
+                <artifactId>mssql-jdbc</artifactId>
+                <version>${sqlserver.jdbc.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.iceberg</groupId>
+                <artifactId>iceberg-flink-runtime-1.14</artifactId>
+                <version>${iceberg.version}</version>
+            </dependency>
+
+            <!-- flink -->
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-api-java-bridge</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-runtime</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-clients</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-table-planner_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+                <scope>test</scope>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-streaming-java</artifactId>
+                <version>${flink.version}</version>
+            </dependency>
+            <dependency>
+                <groupId>org.apache.flink</groupId>
+                <artifactId>flink-streaming-scala_${flink.scala.binary.version}</artifactId>
+                <version>${flink.version}</version>
+            </dependency>

Review Comment:
   > done
   
   @GanfengTan Maybe flink 1.13 module have same problem



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] GanfengTan commented on pull request #8032: [INLONG-8031][Sort][Manager][Agent] Support to dynamically select flink version packaging

Posted by "GanfengTan (via GitHub)" <gi...@apache.org>.
GanfengTan commented on PR #8032:
URL: https://github.com/apache/inlong/pull/8032#issuecomment-1551235266

   > I tested some connector in flink1.13 works fine in flink1.15, how do we manage in this situation ?
   
   I will submit a separate PR for the documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org