You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2022/10/21 12:36:05 UTC
[GitHub] [cxf] jimma opened a new pull request, #1014: [CXF-8758]:Add wiremock-standalone test dependency to fix all tests u…
jimma opened a new pull request, #1014:
URL: https://github.com/apache/cxf/pull/1014
…nder microprofile-client module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] jimma merged pull request #1014: [CXF-8758]:Add wiremock-standalone test dependency to fix all tests u…
Posted by GitBox <gi...@apache.org>.
jimma merged PR #1014:
URL: https://github.com/apache/cxf/pull/1014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] jimma commented on pull request #1014: [CXF-8758]:Add wiremock-standalone test dependency to fix all tests u…
Posted by GitBox <gi...@apache.org>.
jimma commented on PR #1014:
URL: https://github.com/apache/cxf/pull/1014#issuecomment-1296420321
@reta It looks I missed another commit and sent it with another PR : https://github.com/apache/cxf/pull/1018.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] jimma commented on pull request #1014: [CXF-8758]:Add wiremock-standalone test dependency to fix all tests u…
Posted by GitBox <gi...@apache.org>.
jimma commented on PR #1014:
URL: https://github.com/apache/cxf/pull/1014#issuecomment-1293506963
Done. Thanks @reta.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #1014: [CXF-8758]:Add wiremock-standalone test dependency to fix all tests u…
Posted by GitBox <gi...@apache.org>.
reta commented on PR #1014:
URL: https://github.com/apache/cxf/pull/1014#issuecomment-1291951211
> > This is useful trick, thanks @jimma ! Do you think we could wait a bit before merging this one (crossed_fingers the we would have wiremock snapshots available)?
>
> @reta I'd prefer to add this to upstream to show how many jakarta failures left we need to fix before we have a wiremock(with jetty11 update) snapshot available. Because update to wiremock snapshot could be one line change , and it's easy to change after it's available. WDYT ?
>
> > For `system/jaxrs` I was thinking to phase wiremock out (it is used in very limited scope), working on that.
> > That's very cool. Thanks @reta !
@jimma sure, no objections, could you please rebase / merge with main? thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] jimma commented on pull request #1014: [CXF-8758]:Add wiremock-standalone test dependency to fix all tests u…
Posted by GitBox <gi...@apache.org>.
jimma commented on PR #1014:
URL: https://github.com/apache/cxf/pull/1014#issuecomment-1291786729
> This is useful trick, thanks @jimma ! Do you think we could wait a bit before merging this one (🤞 the we would have wiremock snapshots available)?
@reta I'd prefer to add this to upstream to show how many jakarta failures left we need to fix before we have a wiremock(with jetty11 update) snapshot available. Because update to wiremock snapshot could be one line change , and it's easy to change after it's available. WDYT ?
> For `system/jaxrs` I was thinking to phase wiremock out (it is used in very limited scope), working on that.
That's very cool. Thanks @reta !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #1014: [CXF-8758]:Add wiremock-standalone test dependency to fix all tests u…
Posted by GitBox <gi...@apache.org>.
reta commented on PR #1014:
URL: https://github.com/apache/cxf/pull/1014#issuecomment-1287564715
> @reta It seems we pull the com.github.tomakehurst:wiremock-standalone:2.27.2 test scope dependency and it works for all tests under rt/rs/microprofile-client and systests/jaxrs/JAXRSClientMetricsTest. Although this imports some javax servelt and jetty9 artifacts , but they are all for test purpose and doesn't pollute any microprofile client and system test client side dependencies. After the wiremock jakarta version is ready ,we can change back to use the com.github.tomakehurst:wiremock dependency to imports the jakarta servelt and jetty11 dependency. If you want me to include wiremock change for system/jaxrs, please let me know.
This is useful trick, thanks @jimma ! Do you think we could wait a bit before merging this one (🤞 the we would have wiremock snapshots available)? For `system/jaxrs` I was thinking to phase wiremock out (it is used in very limited scope), working on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] jimma commented on pull request #1014: [CXF-8758]:Add wiremock-standalone test dependency to fix all tests u…
Posted by GitBox <gi...@apache.org>.
jimma commented on PR #1014:
URL: https://github.com/apache/cxf/pull/1014#issuecomment-1286911481
@reta It seems we pull the com.github.tomakehurst:wiremock-standalone:2.27.2 test scope dependency and it works for all tests under rt/rs/microprofile-client and systests/jaxrs/JAXRSClientMetricsTest. Although this imports some javax servelt and jetty9 artifacts , but they are all for test purpose and doesn't pollute any microprofile client and system test client side dependencies. After the wiremock jakarta version is ready ,we can change back to use the com.github.tomakehurst:wiremock dependency to imports the jakarta servelt and jetty11 dependency. If you want me to include wiremock change for system/jaxrs, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org