You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/20 22:09:05 UTC
[GitHub] [arrow-datafusion] CodingCat opened a new pull request #912: fix the docker build of datafusion CLI
CodingCat opened a new pull request #912:
URL: https://github.com/apache/arrow-datafusion/pull/912
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/911
# Rationale for this change
the root cause is something easy to fix, we just missed adding rustfmt and a directory mapping
# What changes are included in this PR?
fixes on Dockerfile
# Are there any user-facing changes?
NO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #912: fix the docker build of datafusion CLI
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #912:
URL: https://github.com/apache/arrow-datafusion/pull/912#discussion_r693302950
##########
File path: datafusion-cli/Dockerfile
##########
@@ -21,8 +21,12 @@ COPY ./datafusion /usr/src/datafusion
COPY ./datafusion-cli /usr/src/datafusion-cli
+COPY ./ballista /usr/src/ballista
+
WORKDIR /usr/src/datafusion-cli
+RUN rustup component add rustfmt
Review comment:
what's the reason for adding rustfmt here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #912: fix the docker build of datafusion CLI
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #912:
URL: https://github.com/apache/arrow-datafusion/pull/912#issuecomment-903056398
Thanks @CodingCat , the rest looks good to me, left a minor comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #912: fix the docker build of datafusion CLI
Posted by GitBox <gi...@apache.org>.
andygrove merged pull request #912:
URL: https://github.com/apache/arrow-datafusion/pull/912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #912: fix the docker build of datafusion CLI
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #912:
URL: https://github.com/apache/arrow-datafusion/pull/912#discussion_r693319749
##########
File path: datafusion-cli/Dockerfile
##########
@@ -21,8 +21,12 @@ COPY ./datafusion /usr/src/datafusion
COPY ./datafusion-cli /usr/src/datafusion-cli
+COPY ./ballista /usr/src/ballista
+
WORKDIR /usr/src/datafusion-cli
+RUN rustup component add rustfmt
Review comment:
Ha, good to know, I didn't know tonic_build depends on rustfmt by default for code gen formatting :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] CodingCat commented on a change in pull request #912: fix the docker build of datafusion CLI
Posted by GitBox <gi...@apache.org>.
CodingCat commented on a change in pull request #912:
URL: https://github.com/apache/arrow-datafusion/pull/912#discussion_r693303215
##########
File path: datafusion-cli/Dockerfile
##########
@@ -21,8 +21,12 @@ COPY ./datafusion /usr/src/datafusion
COPY ./datafusion-cli /usr/src/datafusion-cli
+COPY ./ballista /usr/src/ballista
+
WORKDIR /usr/src/datafusion-cli
+RUN rustup component add rustfmt
Review comment:
oh, yeah, otherwise, it tells me
```
#12 71.22 Compiling futures v0.3.16
#12 71.36 Compiling tonic-build v0.5.2
#12 71.71 Compiling bstr v0.2.16
#12 71.74 Compiling lz4 v1.23.2
#12 72.51 Compiling csv v1.1.6
#12 72.54 Compiling arrow-flight v5.2.0
#12 72.83 Compiling ballista-core v0.6.0 (/usr/src/ballista/rust/core)
#12 74.06 Compiling prettytable-rs v0.8.0
#12 74.58 Compiling arrow v5.2.0
#12 75.26 error: failed to run custom build command for `ballista-core v0.6.0 (/usr/src/ballista/rust/core)`
#12 75.26
#12 75.26 Caused by:
#12 75.26 process didn't exit successfully: `/usr/src/datafusion-cli/target/release/build/ballista-core-702be6a42aa8bd82/build-script-build` (exit status: 1)
#12 75.26 --- stdout
#12 75.26 cargo:rerun-if-env-changed=FORCE_REBUILD
#12 75.26 cargo:rerun-if-changed=proto/ballista.proto
#12 75.26
#12 75.26 --- stderr
#12 75.26 error: 'rustfmt' is not installed for the toolchain '1.54.0-x86_64-unknown-linux-gnu'
#12 75.26 To install, run `rustup component add rustfmt`
#12 75.26 warning: build failed, waiting for other jobs to finish...
#12 130.4 error: build failed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org