[GitHub] [arrow-site] Jimexist commented on a change in pull request #142: ARROW-13705: [Website] pin node version to 16 to allow CI and local dev parity

[GitBox <gi...@apache.org>]

Jimexist commented on a change in pull request #142:
URL: https://github.com/apache/arrow-site/pull/142#discussion_r694565752



##########
File path: Rakefile
##########
@@ -23,7 +23,11 @@ webpacked_js = "javascript/main.js"
 installed_package_lock_json = "node_modules/.package-lock.json"
 
 file installed_package_lock_json => ["package.json", "package-lock.json"] do
-  sh("npm", "install", "--no-save")
+  if production?
+    sh("npm", "ci")
+  else
+    sh("npm", "install", "--no-save")
+  end

Review comment:
       https://docs.npmjs.com/cli/v7/commands/npm-ci#description
   
   > This command is similar to npm install, except it's meant to be used in automated environments such as test platforms, continuous integration, and deployment -- or any situation where you want to make sure you're doing a clean install of your dependencies.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org