[jira] [Commented] (BEAM-396) Coder.NonDeterministicException doesn't inherit from Exception

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406643#comment-15406643 ] 

ASF GitHub Bot commented on BEAM-396:
-------------------------------------

GitHub user chandnisingh opened a pull request:

    https://github.com/apache/incubator-beam/pull/776

    BEAM-396 made Coder.NonDeterministic inherit from Exception and not T…

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    …hrowable

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chandnisingh/incubator-beam BEAM-396

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/776.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #776
    
----

----


> Coder.NonDeterministicException doesn't inherit from Exception
> --------------------------------------------------------------
>
>                 Key: BEAM-396
>                 URL: https://issues.apache.org/jira/browse/BEAM-396
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>
> [FindBugs NM_CLASS_NOT_EXCEPTION|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L67]: Class is not derived from an Exception, even though it is named as such.
> Applies to [Coder.NonDeterministicException|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java#L263]
> This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)