[jira] [Work logged] (BEAM-14215) Incomplete argument validation in SnowflakeIO

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-14215?focusedWorklogId=750694&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-750694 ]

ASF GitHub Bot logged work on BEAM-14215:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Mar/22 02:40
            Start Date: 31/Mar/22 02:40
    Worklog Time Spent: 10m 
      Work Description: asf-ci commented on pull request #17223:
URL: https://github.com/apache/beam/pull/17223#issuecomment-1084012264


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 750694)
    Time Spent: 20m  (was: 10m)

> Incomplete argument validation in SnowflakeIO
> ---------------------------------------------
>
>                 Key: BEAM-14215
>                 URL: https://issues.apache.org/jira/browse/BEAM-14215
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-snowflake
>            Reporter: Kamil Breguła (SF)
>            Priority: P2
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Hi.
> I noticed that the validation of arguments from users is not complete, which sometimes leads to problems that are difficult to troubleshoot:
> - The server name or address must be specified, but it is not checked.
> - We have validation for multiple arguments, but only checks if the builder method was called, but the value can still be empty as we use ValueProvider in multiple places.
> Best regards,
> Kamil



--
This message was sent by Atlassian Jira
(v8.20.1#820001)