You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/21 14:17:13 UTC

[GitHub] [cloudstack] ustcweizhou opened a new pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

ustcweizhou opened a new pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335


   ## Description
   <!--- Describe your changes in detail -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   Compare not only the list of management servers but also the lb algorithm when agent connects.
   
   Fixes: #3895
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-696511514


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Spaceman1984 commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-696614681


   > @Spaceman1984 the fix is in, can you test this PR?
   > @blueorangutan package
   
   On it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-696511391


   @blueorangutan test 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-696627388


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2064


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Spaceman1984 commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-697181456


   Tested, LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-696614883


   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-697140427


   Tests LGTM, will merge once @Spaceman1984 can confirm manual testing


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-696499023






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-696498782






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-696936797


   <b>Trillian test result (tid-2827)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 49589 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4335-t2827-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Smoke tests completed. 83 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-696649412


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Spaceman1984 commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-696614681


   > @Spaceman1984 the fix is in, can you test this PR?
   > @blueorangutan package
   
   On it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-696649874


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4335: agent: Compare indirect agent lb algorithm when cloudstack agent conn…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4335:
URL: https://github.com/apache/cloudstack/pull/4335#issuecomment-696511008


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2060


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org