You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "tuhaihe (via GitHub)" <gi...@apache.org> on 2025/10/11 06:02:28 UTC
[I] Makefile：can remove line68-71？ [cloudberry-backup]
tuhaihe opened a new issue, #57:
URL: https://github.com/apache/cloudberry-backup/issues/57
I think we can remove these lines now?
https://github.com/apache/cloudberry-backup/blob/59f10ac645528e9c94d963bf3eaca466a30e9ad2/Makefile#L68-L71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [I] Makefile: can remove line68-71？ [cloudberry-backup]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on issue #57:
URL: https://github.com/apache/cloudberry-backup/issues/57#issuecomment-3395682008
Hi @robertmu, thanks for your reply. So we can add `make unit` without specifying the GPDB version, which is for Cloudberry?
https://github.com/apache/cloudberry-backup/blob/d07ce985d794008a44182a237e20e0ea2eaffa0c/.github/workflows/build_and_unit_test.yml#L41-L44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [I] Makefile: can remove line68-71？ [cloudberry-backup]
Posted by "robertmu (via GitHub)" <gi...@apache.org>.
robertmu commented on issue #57:
URL: https://github.com/apache/cloudberry-backup/issues/57#issuecomment-3395695227
> Hi [@robertmu](https://github.com/robertmu), thanks for your reply. So we can add `make unit` without specifying the GPDB version, which is for Cloudberry?
>
> [cloudberry-backup/.github/workflows/build_and_unit_test.yml](https://github.com/apache/cloudberry-backup/blob/d07ce985d794008a44182a237e20e0ea2eaffa0c/.github/workflows/build_and_unit_test.yml#L41-L44)
>
> Lines 41 to 44 in [d07ce98](/apache/cloudberry-backup/commit/d07ce985d794008a44182a237e20e0ea2eaffa0c)
>
> - name: Unit Test
> run: |
> cd ${GOPATH}/src/github.com/apache/cloudberry-backup
> make unit_all_gpdb_versions
Yes, I agree that the current implementation in build_and_unit_test.yml is correct.
The key improvement we need to make is within the unit_all_gpdb_versions target itself. We should enhance it to support setting parameters like testDbType=CBDB or testDbType=GPDB, along with a specific TEST_DB_VERSION (e.g., 4.0.0), before running the unit tests for each version. This will make our compatibility testing more robust and explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [I] Makefile: can remove line68-71？ [cloudberry-backup]
Posted by "robertmu (via GitHub)" <gi...@apache.org>.
robertmu commented on issue #57:
URL: https://github.com/apache/cloudberry-backup/issues/57#issuecomment-3395675407
Good catch! However I think that these lines should be kept in the `Makefile`. The reasoning is tied to our goal of ensuring `gpbackup` supports a wide range of use cases by maintaining backward compatibility with older GPDB versions, alongside our primary support for Cloudberry Database. This flexibility is critical for certain migration scenarios.
For example, it becomes necessary in constrained environments where a user can only have one database system running at a time due to resource limitations. In this situation, the migration process is necessarily:
1. Use `gpbackup` to take a full backup of the old database (for instance, GPDB 7).
2. Shut down the old database completely.
3. Install and start the new database (e.g., Cloudberry Database).
4. Use `gprestore` to restore the data from the backup.
This workflow means there is a definite requirement for `gpbackup` to reliably back up from older versions like GPDB 7 for a successful restore to Cloudberry Database.
The `unit_all_gpdb_versions` target is therefore a valuable tool for our developers. It provides a quick way to run local regression tests to ensure that code changes do not inadvertently break compatibility for these scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [I] Makefile: can remove line68-71？ [cloudberry-backup]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe closed issue #57: Makefile: can remove line68-71？
URL: https://github.com/apache/cloudberry-backup/issues/57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org