[GitHub] [flink] godfreyhe opened a new pull request #10377: [FLINK-15001] [table-planner-blink] The digest of sub-plan reuse should contain retraction traits for stream physical nodes

[GitBox <gi...@apache.org>]

godfreyhe opened a new pull request #10377: [FLINK-15001] [table-planner-blink] The digest of sub-plan reuse should contain retraction traits for stream physical nodes
URL: https://github.com/apache/flink/pull/10377
 
 
   
   ## What is the purpose of the change
   
   *currently, the digest of sub-plan reuse does not contain retraction traits for stream physical nodes now, which maybe cause two sub-plans be reused even if they have different retraction traits and the result is wrong. The pr aims to fix this issue.*
   
   
   ## Brief change log
   
     - *Add retraction traits to digest in RelDigestWriterImpl*
     - *refactor getDigest method and replace RelDigestWriterImpl with RelTreeWriterImpl*
   
   
   ## Verifying this change
   
   
   This change is already covered by existing tests, such as *DagOptimizationTest*.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services