You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/02/25 22:21:04 UTC
[Impala-ASF-CR] [stress] pull out query and runtime info loading
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12576
Change subject: [stress] pull out query and runtime info loading
......................................................................
[stress] pull out query and runtime info loading
This is an incremental step to reduce the size of concurrent_select.py.
It is now "only" 2019 lines long.
Testing:
Ran various command-line invocations locally, including random and
DML queries. Running a cluster stress test with the modifications.
Change-Id: If65069cd1678cdf71091bd2601bc1fc1d745cec5
---
M tests/comparison/cluster.py
M tests/stress/concurrent_select.py
A tests/stress/queries.py
A tests/stress/runtime_info.py
4 files changed, 479 insertions(+), 410 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/12576/1
--
To view, visit http://gerrit.cloudera.org:8080/12576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If65069cd1678cdf71091bd2601bc1fc1d745cec5
Gerrit-Change-Number: 12576
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] [stress] pull out query and runtime info loading
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12576 )
Change subject: [stress] pull out query and runtime info loading
......................................................................
[stress] pull out query and runtime info loading
This is an incremental step to reduce the size of concurrent_select.py.
It is now "only" 2019 lines long.
Testing:
Ran various command-line invocations locally, including random and
DML queries. Running a cluster stress test with the modifications.
Change-Id: If65069cd1678cdf71091bd2601bc1fc1d745cec5
Reviewed-on: http://gerrit.cloudera.org:8080/12576
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/comparison/cluster.py
M tests/stress/concurrent_select.py
A tests/stress/queries.py
A tests/stress/runtime_info.py
4 files changed, 479 insertions(+), 410 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If65069cd1678cdf71091bd2601bc1fc1d745cec5
Gerrit-Change-Number: 12576
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [stress] pull out query and runtime info loading
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12576 )
Change subject: [stress] pull out query and runtime info loading
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65069cd1678cdf71091bd2601bc1fc1d745cec5
Gerrit-Change-Number: 12576
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 20:12:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [stress] pull out query and runtime info loading
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12576 )
Change subject: [stress] pull out query and runtime info loading
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3836/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65069cd1678cdf71091bd2601bc1fc1d745cec5
Gerrit-Change-Number: 12576
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 20:12:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [stress] pull out query and runtime info loading
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12576 )
Change subject: [stress] pull out query and runtime info loading
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65069cd1678cdf71091bd2601bc1fc1d745cec5
Gerrit-Change-Number: 12576
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 00:08:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [stress] pull out query and runtime info loading
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12576 )
Change subject: [stress] pull out query and runtime info loading
......................................................................
Patch Set 1: Code-Review+2
Seems pretty straightforward.
--
To view, visit http://gerrit.cloudera.org:8080/12576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65069cd1678cdf71091bd2601bc1fc1d745cec5
Gerrit-Change-Number: 12576
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 19:48:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [stress] pull out query and runtime info loading
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12576 )
Change subject: [stress] pull out query and runtime info loading
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2232/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If65069cd1678cdf71091bd2601bc1fc1d745cec5
Gerrit-Change-Number: 12576
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Feb 2019 23:05:01 +0000
Gerrit-HasComments: No