You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2026/09/10 17:05:00 UTC

[jira] [Commented] (OFBIZ-13558) updateBudgetStatus silently succeeds on invalid status transitions

    [ https://issues.apache.org/jira/browse/OFBIZ-13558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113952#comment-18113952 ] 

ASF subversion and git services commented on OFBIZ-13558:
---------------------------------------------------------

Commit d58c46138e9cfa743ba148331df90046fddbb46d in ofbiz-framework's branch refs/heads/trunk from Mridul Pathak
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d58c46138e ]

Fixed: updateBudgetStatus silent success on invalid status transitions (OFBIZ-13558)

Validate status transitions against StatusValidChange and return an error on invalid transitions instead of silently succeeding.


> updateBudgetStatus silently succeeds on invalid status transitions
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-13558
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-13558
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: 24.09.07
>            Reporter: Mridul Pathak
>            Assignee: Mridul Pathak
>            Priority: Minor
>
> In updateBudgetStatus (BudgetServices.groovy), invalid status transitions were silently ignored: when no matching StatusValidChange record was found, the service bypassed createBudgetStatus and returned success(), giving callers the false impression that the status change had been applied.
> Fix updateBudgetStatus to validate transitions against StatusValidChange and return an error (CommonErrorNoStatusValidChange) when the transition is invalid, while preserving initial status creation and idempotent transitions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)