You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajesh Battala <ra...@citrix.com> on 2013/05/09 14:49:19 UTC
Re: Review Request: Fixed Volume which is added thru upload volume is failed
to attach to the instance saying Volume state must be in Allocated,
Ready or in Uploaded state( Though uploaded Volume state is uploaded)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11022/
-----------------------------------------------------------
(Updated May 9, 2013, 12:49 p.m.)
Review request for cloudstack, Devdeep Singh and edison su.
Description
-------
When user uploads the volume, successful uploaded volume state in DB is still marked as "UploadOp"
This is issue with the VolumeServiceImpl, after uploaded operation is successful it should call the stateTransit "UploadOp" to "Uploaded".
Issue is fixed by call the volume state change and now the volume is moved to "uploaded" state which will not throw the exception as the volume is not in ready state.
This addresses bug CLOUDSTACK-2081.
Diffs
-----
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b39502b
Diff: https://reviews.apache.org/r/11022/diff/
Testing
-------
Unittests are running successful.
1. Uploaded the volume, verified the state column in db. during uploading progress its is "UploadOp" after upload is successful it is moved to "Uploaded"
Thanks,
Rajesh Battala
Re: Review Request: Fixed Volume which is added thru upload volume is failed
to attach to the instance saying Volume state must be in Allocated,
Ready or in Uploaded state( Though uploaded Volume state is uploaded)
Posted by Devdeep Singh <de...@citrix.com>.
> On May 17, 2013, 9:44 a.m., Devdeep Singh wrote:
> > Ship It!
Committed the changes to master. Kindly close this request.
- Devdeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11022/#review20698
-----------------------------------------------------------
On May 9, 2013, 12:49 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11022/
> -----------------------------------------------------------
>
> (Updated May 9, 2013, 12:49 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and edison su.
>
>
> Description
> -------
>
> When user uploads the volume, successful uploaded volume state in DB is still marked as "UploadOp"
>
> This is issue with the VolumeServiceImpl, after uploaded operation is successful it should call the stateTransit "UploadOp" to "Uploaded".
> Issue is fixed by call the volume state change and now the volume is moved to "uploaded" state which will not throw the exception as the volume is not in ready state.
>
>
> This addresses bug CLOUDSTACK-2081.
>
>
> Diffs
> -----
>
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b39502b
>
> Diff: https://reviews.apache.org/r/11022/diff/
>
>
> Testing
> -------
>
> Unittests are running successful.
>
> 1. Uploaded the volume, verified the state column in db. during uploading progress its is "UploadOp" after upload is successful it is moved to "Uploaded"
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request: Fixed Volume which is added thru upload volume is failed
to attach to the instance saying Volume state must be in Allocated,
Ready or in Uploaded state( Though uploaded Volume state is uploaded)
Posted by Rajesh Battala <ra...@citrix.com>.
> On May 17, 2013, 9:44 a.m., Devdeep Singh wrote:
> > Ship It!
>
> Devdeep Singh wrote:
> Committed the changes to master. Kindly close this request.
Thanks for pushing to master.
- Rajesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11022/#review20698
-----------------------------------------------------------
On May 9, 2013, 12:49 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11022/
> -----------------------------------------------------------
>
> (Updated May 9, 2013, 12:49 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and edison su.
>
>
> Description
> -------
>
> When user uploads the volume, successful uploaded volume state in DB is still marked as "UploadOp"
>
> This is issue with the VolumeServiceImpl, after uploaded operation is successful it should call the stateTransit "UploadOp" to "Uploaded".
> Issue is fixed by call the volume state change and now the volume is moved to "uploaded" state which will not throw the exception as the volume is not in ready state.
>
>
> This addresses bug CLOUDSTACK-2081.
>
>
> Diffs
> -----
>
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b39502b
>
> Diff: https://reviews.apache.org/r/11022/diff/
>
>
> Testing
> -------
>
> Unittests are running successful.
>
> 1. Uploaded the volume, verified the state column in db. during uploading progress its is "UploadOp" after upload is successful it is moved to "Uploaded"
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request: Fixed Volume which is added thru upload volume is failed
to attach to the instance saying Volume state must be in Allocated,
Ready or in Uploaded state( Though uploaded Volume state is uploaded)
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11022/#review20698
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On May 9, 2013, 12:49 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11022/
> -----------------------------------------------------------
>
> (Updated May 9, 2013, 12:49 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and edison su.
>
>
> Description
> -------
>
> When user uploads the volume, successful uploaded volume state in DB is still marked as "UploadOp"
>
> This is issue with the VolumeServiceImpl, after uploaded operation is successful it should call the stateTransit "UploadOp" to "Uploaded".
> Issue is fixed by call the volume state change and now the volume is moved to "uploaded" state which will not throw the exception as the volume is not in ready state.
>
>
> This addresses bug CLOUDSTACK-2081.
>
>
> Diffs
> -----
>
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b39502b
>
> Diff: https://reviews.apache.org/r/11022/diff/
>
>
> Testing
> -------
>
> Unittests are running successful.
>
> 1. Uploaded the volume, verified the state column in db. during uploading progress its is "UploadOp" after upload is successful it is moved to "Uploaded"
>
>
> Thanks,
>
> Rajesh Battala
>
>