[GitHub] HeartSaVioR commented on a change in pull request #23916: [SPARK-22000][SQL][FOLLOWUP] Add comment and simple cleanup to DeserializerBuildHelper

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #23916: [SPARK-22000][SQL][FOLLOWUP] Add comment and simple cleanup to DeserializerBuildHelper
URL: https://github.com/apache/spark/pull/23916#discussion_r261056537
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala
 ##########
 @@ -44,25 +44,38 @@ object DeserializerBuildHelper {
     upCastToExpectedType(newPath, dataType, walkedTypePath)
   }
 
+  /**
+   * Returns an expression that can be used to deserialize input expression.
+   *
+   * @param expr The input expression that can be used to extract serialized value.
+   * @param nullable Whether deserialized expression evalutes to null value.
+   * @param walkedTypePath The paths from top to bottom to access current field when deserializing.
+   * @param funcForCreatingDeserializer Given input expression and typed path, this function
+   *                                    returns deserializer expression.
+   */
   def deserializerForWithNullSafety(
 
 Review comment:
   I think `expressionWithNullSafety` is more general naming so might be preferred one, but `deserializerForWithNullSafety` is also a good name cause we have relevant method `deserializerForWithNullSafetyAndUpcast`. 
   
   So that's a matter of preference and either can be removed. Which method would we prefer to keep?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org