[GitHub] [arrow] pitrou commented on a change in pull request #7504: ARROW-9193: [C++] Add method to parse date from null-terminated string

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #7504:
URL: https://github.com/apache/arrow/pull/7504#discussion_r443428904



##########
File path: cpp/src/arrow/util/value_parsing.h
##########
@@ -565,6 +565,39 @@ static inline bool ParseTimestampStrptime(const char* buf, size_t length,
   return true;
 }
 
+/// \brief Returns time since the UNIX epoch in the requested unit. Takes null terminated
+/// buffer as argument
+static inline bool ParseTimestampStrptimeFromCString(const char* buf, size_t length,

Review comment:
       Can you please refactor these two functions to avoid duplicated code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org