You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Arjun Mishra via Review Board <no...@reviews.apache.org> on 2018/06/26 00:18:43 UTC

Re: Review Request 67218: SENTRY-2238: Explicitly set Database on SentryHivePrivilegeObjectDesc

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67218/
-----------------------------------------------------------

(Updated June 26, 2018, 12:18 a.m.)


Review request for sentry, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.


Summary (updated)
-----------------

SENTRY-2238: Explicitly set Database on SentryHivePrivilegeObjectDesc


Repository: sentry


Description
-------

Right now database is not supported with command SHOW GRANT ROLE/USER ON DATABASE


Diffs
-----

  sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java 4fa4221b4 
  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 660bef115 
  sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java 8b6b223da 


Diff: https://reviews.apache.org/r/67218/diff/2/


Testing
-------

mvn -f sentry-binding/pom.xml test


Thanks,

Arjun Mishra


Re: Review Request 67218: SENTRY-2238: Explicitly set Database on SentryHivePrivilegeObjectDesc

Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67218/#review205341
-----------------------------------------------------------


Ship it!




Ship It!

- Na Li


On June 26, 2018, 12:18 a.m., Arjun Mishra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67218/
> -----------------------------------------------------------
> 
> (Updated June 26, 2018, 12:18 a.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Right now database is not supported with command SHOW GRANT ROLE/USER ON DATABASE
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java 4fa4221b4 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 660bef115 
>   sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java 8b6b223da 
> 
> 
> Diff: https://reviews.apache.org/r/67218/diff/2/
> 
> 
> Testing
> -------
> 
> mvn -f sentry-binding/pom.xml test
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>


Re: Review Request 67218: SENTRY-2238: Explicitly set Database on SentryHivePrivilegeObjectDesc

Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67218/#review205369
-----------------------------------------------------------


Ship it!




Ship It!

- Sergio Pena


On June 26, 2018, 12:18 a.m., Arjun Mishra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67218/
> -----------------------------------------------------------
> 
> (Updated June 26, 2018, 12:18 a.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Right now database is not supported with command SHOW GRANT ROLE/USER ON DATABASE
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java 4fa4221b4 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 660bef115 
>   sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java 8b6b223da 
> 
> 
> Diff: https://reviews.apache.org/r/67218/diff/2/
> 
> 
> Testing
> -------
> 
> mvn -f sentry-binding/pom.xml test
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>