[PATCH] issue #3232: ignore mixed EOL in ignored part of commit message (was:Re: Please review & apply my patch)

[Richard Hartmann <ri...@gmail.com>]

[[[
Fix issue #3232: Actually ignore mixed EOL in ignored part of commit message

* subversion/svn/util.c
  Truncate first, check afterwards
* tests/cmdline/commit_tests.py
  Test mixed EOL both before & after ignore line
]]]

While the tests run with the expected results, trying to actually commit
something with a 'broken' log message does not work. I assume the
error lies with not copying back log_msg into log_msg_string, but I am
not sure. Furthermore, test 30 should fail, but it does not.


Any help appreciated,
Richard

PS: Thanks to danielsh for pointing me to the coding guidelines :)

PPS: Be gentle, neither my C nor my Python is too good. If the
test were written in Perl, well.. ;)

Re: [PATCH] issue #3232: ignore mixed EOL in ignored part of commit message (was:Re: Please review & apply my patch)

[Richard Hartmann <ri...@gmail.com>]

On Thu, Jul 10, 2008 at 20:43, Daniel Shahaf <d....@daniel.shahaf.co.il> wrote:

> Can you provide a newer version of the patch that fixes these points?
> If you need help (e.g. understanding the code), feel free to ask.

The test should be OK now and I looked at the C code, but since then
I did not have time to address this again. I hope to be able to do so
over the weekend.


Richard

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] issue #3232: ignore mixed EOL in ignored part of commit message (was:Re: Please review & apply my patch)

[Daniel Shahaf <d....@daniel.shahaf.co.il>]

Richard Hartmann wrote on Sat, 5 Jul 2008 at 15:25 +0200:
> [[[
> Fix issue #3232: Actually ignore mixed EOL in ignored part of commit message
> 
> * subversion/svn/util.c
>   Truncate first, check afterwards
> * tests/cmdline/commit_tests.py
>   Test mixed EOL both before & after ignore line
> ]]]
> 
> While the tests run with the expected results, trying to actually commit
> something with a 'broken' log message does not work. I assume the
> error lies with not copying back log_msg into log_msg_string, but I am
> not sure. Furthermore, test 30 should fail, but it does not.

Can you provide a newer version of the patch that fixes these points?
If you need help (e.g. understanding the code), feel free to ask.

Daniel


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org