[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #1035: IGNITE-17575 Create a Hash Index Storage per partition

[GitBox <gi...@apache.org>]

SammyVimes commented on code in PR #1035:
URL: https://github.com/apache/ignite-3/pull/1035#discussion_r954822667


##########
modules/storage-api/src/test/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java:
##########
@@ -70,38 +85,65 @@ void setUp() {
     }
 
     @AfterEach
-    void tearDown() {
-        tableStorage.destroy();
+    void tearDownBase() {
+        tableStorage.stop();
     }
 
     /**
-     * Tests creating a partition.
+     * Tests that {@link MvTableStorage#getMvPartition(int)} correctly returns an existing partition.
      */
     @Test
-    public void testCreatePartition() {
-        int partitionId = 0;
+    void testCreatePartition() {
+        MvPartitionStorage absentStorage = tableStorage.getMvPartition(0);
+
+        assertThat(absentStorage, is(nullValue()));
+
+        MvPartitionStorage partitionStorage = tableStorage.getOrCreateMvPartition(0);
+
+        assertThat(partitionStorage, is(notNullValue()));
+
+        var testData = binaryRow(new TestKey(1, "1"), new TestValue(10, "10"));
 
-        assertThat(tableStorage.getMvPartition(partitionId), is(nullValue()));
+        partitionStorage.runConsistently(() -> {
+            UUID txId = UUID.randomUUID();
 
-        assertThat(tableStorage.getOrCreateMvPartition(partitionId), is(notNullValue()));
+            RowId rowId = partitionStorage.insert(testData, txId);
 
-        assertThat(tableStorage.getMvPartition(partitionId), is(notNullValue()));
+            assertThat(partitionStorage, is(sameInstance(tableStorage.getMvPartition(0))));
+
+            assertThat(unwrap(partitionStorage.read(rowId, txId)), is(equalTo(unwrap(testData))));

Review Comment:
   I thought we are only testing the returnal of the partition storage



##########
modules/storage-api/src/test/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java:
##########
@@ -70,38 +85,65 @@ void setUp() {
     }
 
     @AfterEach
-    void tearDown() {
-        tableStorage.destroy();
+    void tearDownBase() {
+        tableStorage.stop();
     }
 
     /**
-     * Tests creating a partition.
+     * Tests that {@link MvTableStorage#getMvPartition(int)} correctly returns an existing partition.
      */
     @Test
-    public void testCreatePartition() {
-        int partitionId = 0;
+    void testCreatePartition() {
+        MvPartitionStorage absentStorage = tableStorage.getMvPartition(0);
+
+        assertThat(absentStorage, is(nullValue()));
+
+        MvPartitionStorage partitionStorage = tableStorage.getOrCreateMvPartition(0);
+
+        assertThat(partitionStorage, is(notNullValue()));
+
+        var testData = binaryRow(new TestKey(1, "1"), new TestValue(10, "10"));

Review Comment:
   illegal `var`



##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/HashIndices.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.storage.rocksdb;
+
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import org.apache.ignite.internal.rocksdb.ColumnFamily;
+import org.apache.ignite.internal.storage.index.HashIndexDescriptor;
+import org.apache.ignite.internal.storage.index.HashIndexStorage;
+import org.apache.ignite.internal.storage.rocksdb.index.RocksDbHashIndexStorage;
+
+class HashIndices {
+    private final HashIndexDescriptor descriptor;
+
+    private final ConcurrentMap<Integer, HashIndexStorage> storages = new ConcurrentHashMap<>();

Review Comment:
   I wonder if we actually need concurrent map here. Chances are, we only create indices in one thread and access in other thread strictly after the creation. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org