[GitHub] john-bodley closed pull request #5533: [ad-hoc filters] Remove legacy split in /explore

[GitBox <gi...@apache.org>]

john-bodley closed pull request #5533: [ad-hoc filters] Remove legacy split in /explore
URL: https://github.com/apache/incubator-superset/pull/5533
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/views/core.py b/superset/views/core.py
index a49f37e4b5..0e41d4576b 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1280,10 +1280,9 @@ def explore(self, datasource_type=None, datasource_id=None):
 
         form_data['datasource'] = str(datasource_id) + '__' + datasource_type
 
-        # On explore, merge extra filters into the form data
+        # On explore, merge legacy and extra filters into the form data
         utils.convert_legacy_filters_into_adhoc(form_data)
         merge_extra_filters(form_data)
-        utils.split_adhoc_filters_into_base_filters(form_data)
 
         # merge request url params
         if request.method == 'GET':


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org