You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/08/08 12:57:14 UTC
[GitHub] [guacamole-client] necouchman commented on a diff in pull request #752: GUACAMOLE-1612: Fix/Add italian translations
necouchman commented on code in PR #752:
URL: https://github.com/apache/guacamole-client/pull/752#discussion_r940201276
##########
extensions/guacamole-auth-duo/src/main/resources/translations/it.json:
##########
@@ -0,0 +1,13 @@
+{
+
+ "DATA_SOURCE_DUO" : {
+ "NAME" : "Duo TFA Backend"
+ },
+
+ "LOGIN" : {
+ "FIELD_HEADER_GUAC_DUO_SIGNED_RESPONSE" : "",
Review Comment:
You can leave out empty translation strings - there's no reason to include them.
##########
extensions/guacamole-auth-duo/src/main/resources/translations/it.json:
##########
@@ -0,0 +1,13 @@
+{
+
+ "DATA_SOURCE_DUO" : {
+ "NAME" : "Duo TFA Backend"
Review Comment:
If this is the Italian translation of the English "Duo TFA Backend", then this can stay - otherwise, no need to include it.
##########
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/translations/it.json:
##########
@@ -0,0 +1,26 @@
+{
+
+ "DATA_SOURCE_CAS" : {
+ "NAME" : "CAS SSO Backend"
+ },
+
+ "DATA_SOURCE_OPENID" : {
+ "NAME" : "OpenID SSO Backend"
+ },
+
+ "DATA_SOURCE_SAML" : {
+ "NAME" : "SAML SSO Backend"
+ },
+
+ "LOGIN" : {
+ "FIELD_HEADER_ID_TOKEN" : "",
+ "FIELD_HEADER_STATE" : "",
+ "FIELD_HEADER_TICKET" : "",
Review Comment:
No reason to include empty strings.
##########
extensions/guacamole-auth-totp/src/main/resources/translations/it.json:
##########
@@ -0,0 +1,43 @@
+{
+
+ "DATA_SOURCE_TOTP" : {
+ "NAME" : "TOTP TFA Backend"
+ },
+
+ "LOGIN" : {
+ "FIELD_HEADER_GUAC_TOTP" : ""
Review Comment:
No reason to include empty strings.
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/resources/translations/it.json:
##########
@@ -0,0 +1,113 @@
+{
+
+ "LOGIN" : {
+
+ "ERROR_PASSWORD_BLANK" : "@:APP.ERROR_PASSWORD_BLANK",
Review Comment:
I think you can leave out any of these references to other translation strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org