[jira] [Updated] (HADOOP-10926) Improve test-patch.sh to apply binary diffs

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Patrick McCabe updated HADOOP-10926:
------------------------------------------
    Attachment: HADOOP-10926.001.patch

Here's a patch which implements this in smart-apply-patch.sh.  I opted to use "git apply" only for git patches.  This is because "git apply" doesn't implement all the quirks of the GNU patch format.  So we get maximum compatibility by continuing to use GNU patch for any non-git files.  Checking if something is generated by git is easy.  I also added a bit of error dumping when patch application fails.

> Improve test-patch.sh to apply binary diffs
> -------------------------------------------
>
>                 Key: HADOOP-10926
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10926
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Andrew Wang
>            Assignee: Colin Patrick McCabe
>         Attachments: HADOOP-10926.001.patch
>
>
> The Unix {{patch}} command cannot apply binary diffs as generated via {{git diff --binary}}. This means we cannot get effective test-patch.sh runs when the patch requires adding a binary file.
> We should consider using a different patch method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)