[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #84: [FLINK-27139] FileStoreCommitImpl#filterCommitted should exit when faced with expired files

[GitBox <gi...@apache.org>]

JingsongLi commented on code in PR #84:
URL: https://github.com/apache/flink-table-store/pull/84#discussion_r846014574


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java:
##########
@@ -129,8 +130,18 @@ public FileStoreCommit withLock(Lock lock) {
             identifiers.put(committable.identifier(), committable);
         }
 
-        for (long id = latestSnapshotId; id >= Snapshot.FIRST_SNAPSHOT_ID; id--) {
+        for (long id = latestSnapshotId;
+                id >= Snapshot.FIRST_SNAPSHOT_ID && !identifiers.isEmpty();

Review Comment:
   return at the begaining of the method?
   ```
   if (committableList.isEmpty) {
     return committableList;
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org