You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sangeeta Ravindran <sa...@gmail.com> on 2017/01/26 19:44:26 UTC
Review Request 55993: On Capacity Scheduler view,
click "*" button for "Node label Access" the 2nd time should de-select all
node labels, but it doesn't
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55993/
-----------------------------------------------------------
Review request for Ambari, Di Li and Gaurav Nagar.
Bugs: AMBARI-19680
https://issues.apache.org/jira/browse/AMBARI-19680
Repository: ambari
Description
-------
1. Enable Node Labels and restart Yarn.
2. Add some node labels using the command below:
[yarn@turns1 ~]$ yarn rmadmin -addToClusterNodeLabels "high_cpu,high_mem"
[yarn@turns1 ~]$ yarn rmadmin -replaceLabelsOnNode "<host_name>=high_cpu <host_name>=high_mem"
3. Go to Capacity Scheduler view, click root queue, by default the "Enable node labels" button has been checked.
4. Click "*" button beside "Node Label Access", it will automatically make all node labels (high_cpu, high_mem) selected. Change capacity for the 2 node labels to 100%.
5. Click this button again, it should de-select the node labels, but it doesn't.
This seems to happen because the list of labels for the selected queue is not cleared when the "*" button is deselected.
Diffs
-----
contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js df0c684
Diff: https://reviews.apache.org/r/55993/diff/
Testing
-------
Manual Testing. Enabling disabling the * button. Ran mvn test.
Thanks,
Sangeeta Ravindran
Re: Review Request 55993: On Capacity Scheduler view,
click "*" button for "Node label Access" the 2nd time should de-select all
node labels, but it doesn't
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55993/#review163165
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On Jan. 26, 2017, 7:44 p.m., Sangeeta Ravindran wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55993/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 7:44 p.m.)
>
>
> Review request for Ambari, Di Li and Gaurav Nagar.
>
>
> Bugs: AMBARI-19680
> https://issues.apache.org/jira/browse/AMBARI-19680
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Enable Node Labels and restart Yarn.
> 2. Add some node labels using the command below:
> [yarn@turns1 ~]$ yarn rmadmin -addToClusterNodeLabels "high_cpu,high_mem"
> [yarn@turns1 ~]$ yarn rmadmin -replaceLabelsOnNode "<host_name>=high_cpu <host_name>=high_mem"
> 3. Go to Capacity Scheduler view, click root queue, by default the "Enable node labels" button has been checked.
> 4. Click "*" button beside "Node Label Access", it will automatically make all node labels (high_cpu, high_mem) selected. Change capacity for the 2 node labels to 100%.
> 5. Click this button again, it should de-select the node labels, but it doesn't.
>
> This seems to happen because the list of labels for the selected queue is not cleared when the "*" button is deselected.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js df0c684
>
> Diff: https://reviews.apache.org/r/55993/diff/
>
>
> Testing
> -------
>
> Manual Testing. Enabling disabling the * button. Ran mvn test.
>
>
> Thanks,
>
> Sangeeta Ravindran
>
>
Re: Review Request 55993: On Capacity Scheduler view,
click "*" button for "Node label Access" the 2nd time should de-select all
node labels, but it doesn't
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55993/#review163389
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Jan. 26, 2017, 7:44 p.m., Sangeeta Ravindran wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55993/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 7:44 p.m.)
>
>
> Review request for Ambari, Di Li and Gaurav Nagar.
>
>
> Bugs: AMBARI-19680
> https://issues.apache.org/jira/browse/AMBARI-19680
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Enable Node Labels and restart Yarn.
> 2. Add some node labels using the command below:
> [yarn@turns1 ~]$ yarn rmadmin -addToClusterNodeLabels "high_cpu,high_mem"
> [yarn@turns1 ~]$ yarn rmadmin -replaceLabelsOnNode "<host_name>=high_cpu <host_name>=high_mem"
> 3. Go to Capacity Scheduler view, click root queue, by default the "Enable node labels" button has been checked.
> 4. Click "*" button beside "Node Label Access", it will automatically make all node labels (high_cpu, high_mem) selected. Change capacity for the 2 node labels to 100%.
> 5. Click this button again, it should de-select the node labels, but it doesn't.
>
> This seems to happen because the list of labels for the selected queue is not cleared when the "*" button is deselected.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js df0c684
>
> Diff: https://reviews.apache.org/r/55993/diff/
>
>
> Testing
> -------
>
> Manual Testing. Enabling disabling the * button. Ran mvn test.
>
>
> Thanks,
>
> Sangeeta Ravindran
>
>