You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Nick Kew <ni...@webthing.com> on 2008/01/08 18:25:24 UTC
Re: svn commit: r610061 -
/httpd/httpd/trunk/modules/http/http_filters.c
On Tue, 08 Jan 2008 16:38:15 -0000
rpluem@apache.org wrote:
> + if ((len == 0) || (lineend[len - 1] != APR_ASCII_LF)) {
> return APR_EAGAIN;
> }
Isn't that a potential infinite loop? The zero-length bucket
will still be there next time round.
if (len == 0) { remove(b); try p->prev; }
--
Nick Kew
Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/
Re: svn commit: r610061 - /httpd/httpd/trunk/modules/http/http_filters.c
Posted by Ruediger Pluem <rp...@apache.org>.
On 01/08/2008 06:25 PM, Nick Kew wrote:
> On Tue, 08 Jan 2008 16:38:15 -0000
> rpluem@apache.org wrote:
>
>> + if ((len == 0) || (lineend[len - 1] != APR_ASCII_LF)) {
>> return APR_EAGAIN;
>> }
>
> Isn't that a potential infinite loop? The zero-length bucket
> will still be there next time round.
No. This is outside of the for loop and next time we have a new bucket brigade.
Regards
Rüdiger