[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #286: renamed wholeLine variable to triggerText

[GitBox <gi...@apache.org>]

stevedlawrence commented on code in PR #286:
URL: https://github.com/apache/daffodil-vscode/pull/286#discussion_r966290666


##########
src/language/providers/attributeCompletion.ts:
##########
@@ -75,19 +75,19 @@ export function getAttributeCompletionProvider() {
         document: vscode.TextDocument,
         position: vscode.Position
       ) {
-        const wholeLine = document
+        const triggerText = document
           .lineAt(position)
           .text.substr(0, position.character)
         var nearestOpenItem = nearestOpen(document, position)
 
         if (
           !checkBraceOpen(document, position) &&
-          !wholeLine.includes('assert') &&
+          !triggerText.includes('assert') &&
           !nearestOpenItem.includes('none')
         ) {
           if (nearestOpenItem.includes('element')) {
             var preVal = ''
-            if (!wholeLine.includes('xs:element')) {
+            if (!triggerText.includes('xs:element')) {

Review Comment:
   Agreed. This feels like a pretty important change to tackle sooner rather than later, since more and more schemas are now being written without the xs: prefixes on tags. I believe issue #120 is about fixing that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org