You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/31 15:15:47 UTC

[GitHub] [rocketmq] TheR1sing3un opened a new issue, #4959: Fix the logic when deal with a read_event with empty events(the log need to be appended by DLedger)

TheR1sing3un opened a new issue, #4959:
URL: https://github.com/apache/rocketmq/issues/4959

   > DLedgerController.ControllerEventHandler#run()
   
   ![image](https://user-images.githubusercontent.com/87409330/187713599-c5dd92d9-440c-4740-8b35-4434d3bc2a43.png)
   
   If a write_event has been processed and responsed with empty events(DLedger log), we shouldn't ingore it, we must regard it as a read event because this event has accessed the controller state machine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] TheR1sing3un commented on issue #4959: Fix the logic when deal with a read_event with empty events(the log need to be appended by DLedger)

Posted by GitBox <gi...@apache.org>.

TheR1sing3un commented on issue #4959:
URL: https://github.com/apache/rocketmq/issues/4959#issuecomment-1233648091

   > Hello @TheR1sing3un 
   > The theme and the PR changes don't match, I guess
   > 
   > It should be
   > 
   > Fix the logic when deal with a `write_event` with empty events(the log need to be appended by DLedger)
   
   Yes！Thks！


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed issue #4959: Fix the logic when deal with a write_event with empty events(the log need to be appended by DLedger)

Posted by GitBox <gi...@apache.org>.

RongtongJin closed issue #4959: Fix the logic when deal with a write_event with empty events(the log need to be appended by DLedger)
URL: https://github.com/apache/rocketmq/issues/4959


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] Oliverwqcwrw commented on issue #4959: Fix the logic when deal with a read_event with empty events(the log need to be appended by DLedger)

Posted by GitBox <gi...@apache.org>.

Oliverwqcwrw commented on issue #4959:
URL: https://github.com/apache/rocketmq/issues/4959#issuecomment-1233618189

   Hello @TheR1sing3un 
   The theme and the PR changes don't match, I guess
   
   It should be
   
   Fix the logic when deal with a `write_event` with empty events(the log need to be appended by DLedger)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org