[lucene-solr] 02/03: SOLR-14749: Fix some precommit issues.

[ab...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ab pushed a commit to branch jira/solr-14749-api
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git

commit 30eedeaad42f612d4127448efe70e1053f1e44f8
Author: Andrzej Bialecki <ab...@apache.org>
AuthorDate: Mon Nov 2 12:47:35 2020 +0100

    SOLR-14749: Fix some precommit issues.
---
 .../solr/core/ClusterEventProducerFactory.java       |  2 +-
 .../cluster/events/ClusterEventProducerTest.java     | 20 +++++++++++++++-----
 2 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/solr/core/src/java/org/apache/solr/core/ClusterEventProducerFactory.java b/solr/core/src/java/org/apache/solr/core/ClusterEventProducerFactory.java
index 0a38414..7142cba 100644
--- a/solr/core/src/java/org/apache/solr/core/ClusterEventProducerFactory.java
+++ b/solr/core/src/java/org/apache/solr/core/ClusterEventProducerFactory.java
@@ -68,7 +68,7 @@ public class ClusterEventProducerFactory implements ClusterEventProducer {
    * Create a {@link ClusterEventProducer} based on the current plugin configurations.
    * <p>NOTE: this method can only be called once because it has side-effects, such as
    * transferring the initially collected listeners to the resulting producer's instance, and
-   * installing a {@link ContainerPluginsRegistry.PluginRegistryListener}.
+   * installing a {@link org.apache.solr.api.ContainerPluginsRegistry.PluginRegistryListener}.
    * Calling this method more than once will result in an exception.</p>
    * @param plugins current plugin configurations
    * @return configured instance of cluster event producer (with side-effects, see above)
diff --git a/solr/core/src/test/org/apache/solr/cluster/events/ClusterEventProducerTest.java b/solr/core/src/test/org/apache/solr/cluster/events/ClusterEventProducerTest.java
index 3abd4b2..e5b8661 100644
--- a/solr/core/src/test/org/apache/solr/cluster/events/ClusterEventProducerTest.java
+++ b/solr/core/src/test/org/apache/solr/cluster/events/ClusterEventProducerTest.java
@@ -185,16 +185,22 @@ public class ClusterEventProducerTest extends SolrCloudTestCase {
     @Override
     public void onEvent(ClusterEvent event) {
       if (state != State.RUNNING) {
-        log.debug("skipped event, not running: {}", event);
+        if (log.isDebugEnabled()) {
+          log.debug("skipped event, not running: {}", event);
+        }
         return;
       }
       if (event.getType() == ClusterEvent.EventType.COLLECTIONS_ADDED ||
           event.getType() == ClusterEvent.EventType.COLLECTIONS_REMOVED) {
-        log.debug("recorded event {}", Utils.toJSONString(event));
+        if (log.isDebugEnabled()) {
+          log.debug("recorded event {}", Utils.toJSONString(event));
+        }
         lastEvent = event;
         dummyEventLatch.countDown();
       } else {
-        log.debug("skipped event, wrong type: {}", event.getType());
+        if (log.isDebugEnabled()) {
+          log.debug("skipped event, wrong type: {}", event.getType());
+        }
       }
     }
 
@@ -205,7 +211,9 @@ public class ClusterEventProducerTest extends SolrCloudTestCase {
 
     @Override
     public void start() throws Exception {
-      log.debug("starting {}", Integer.toHexString(hashCode()));
+      if (log.isDebugEnabled()) {
+        log.debug("starting {}", Integer.toHexString(hashCode()));
+      }
       state = State.RUNNING;
     }
 
@@ -216,7 +224,9 @@ public class ClusterEventProducerTest extends SolrCloudTestCase {
 
     @Override
     public void stop() {
-      log.debug("stopping {}", Integer.toHexString(hashCode()));
+      if (log.isDebugEnabled()) {
+        log.debug("stopping {}", Integer.toHexString(hashCode()));
+      }
       state = State.STOPPED;
     }
   }