You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/11/17 01:59:32 UTC

[GitHub] [phoenix] yanxinyi commented on a change in pull request #960: PHOENIX-6155 : Provide a coprocessor endpoint to avoid direct upserts into SYSTEM.TASK from the client

yanxinyi commented on a change in pull request #960:
URL: https://github.com/apache/phoenix/pull/960#discussion_r524835690



##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java
##########
@@ -319,6 +321,10 @@ public void testUpdatedSplitPolicyForSysTask() throws Exception {
                 + compatibleClientVersion,
                 tableDescriptor.getRegionSplitPolicyClassName(),
                 SystemTaskSplitPolicy.class.getName());
+            assertTrue("Coprocessor " + TaskMetaDataEndpoint.class.getName()
+                + " has not been added with compatible client version: "
+                + compatibleClientVersion, tableDescriptor.hasCoprocessor(
+                    TaskMetaDataEndpoint.class.getName()));

Review comment:
       nice check for the coproc




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org