You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by xccui <gi...@git.apache.org> on 2017/10/13 03:39:18 UTC

[GitHub] flink pull request #4819: [FLINK-7764] [kafka] Fix the operator setting prob...

GitHub user xccui opened a pull request:

    https://github.com/apache/flink/pull/4819

    [FLINK-7764] [kafka] Fix the operator setting problem of FlinkKafkaProducer010(1.3)

    ## What is the purpose of the change
    
    This PR fixes the operator setting (name, uid, parallelism, etc.) problem of FlinkKafkaProducer010 for `release-1.3` branch.
    
    
    ## Brief change log
    
      - Override all the DataStreamSink public methods in FlinkKafkaProducer010.FlinkKafkaProducer010Configuration
      - Fix the typo names "FlinKafkaProducer" ==> "FlinkKafkaProducer".
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xccui/flink FLINK-7764-1.3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4819.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4819
    
----
commit d2fd6cc1c7b074f7810c7034a4a87e8d8a1fe074
Author: Xingcan Cui <xi...@gmail.com>
Date:   2017-10-11T15:42:29Z

    [FLINK-7764] [kafka] Enable the operator settings for FlinkKafkaProducer010
    
    [hotfix] [kafka] Fix the config parameter names in KafkaTestBase.

----


---

[GitHub] flink issue #4819: [FLINK-7764] [kafka] Fix the operator setting problem of ...

Posted by xccui <gi...@git.apache.org>.

Github user xccui commented on the issue:

    https://github.com/apache/flink/pull/4819
  
    Thanks @aljoscha. Will close this PR.


---

[GitHub] flink pull request #4819: [FLINK-7764] [kafka] Fix the operator setting prob...

Posted by xccui <gi...@git.apache.org>.

Github user xccui closed the pull request at:

    https://github.com/apache/flink/pull/4819


---

[GitHub] flink issue #4819: [FLINK-7764] [kafka] Fix the operator setting problem of ...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4819
  
    I also merged this one. 👍 
    
    Could you please close the PR?


---