[GitHub] [iceberg] kbendick commented on a change in pull request #3998: Flink: Support override write configuration on top of table properties in FlinkSink builder

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #3998:
URL: https://github.com/apache/iceberg/pull/3998#discussion_r796203579



##########
File path: flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -288,7 +295,7 @@ public Builder uidPrefix(String newPrefix) {
 
       // Distribute the records from input data stream based on the write.distribution-mode.
       DataStream<RowData> distributeStream = distributeDataStream(
-          rowDataInput, table.properties(), table.spec(), table.schema(), flinkRowType);
+          rowDataInput, this.props, table.spec(), table.schema(), flinkRowType);

Review comment:
       Nit: We don't use `this` to access instance variables typically other than in the constructors and places that we modify class properties directly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org