You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Joe Swatosh <jo...@gmail.com> on 2007/01/03 01:35:56 UTC

[PATCH] Release memory aquired with ruby_xmalloc with ruby_xfree

Hi All,

I found this when I tried to run a debug build.  Not sure how
important it is, but it seems like a good idea.

[[[
* subversion/bindings/swig/core.i
  Release memory aquired with ruby_xmalloc with ruby_xfree.
]]]

Index: subversion/bindings/swig/core.i
===================================================================
--- subversion/bindings/swig/core.i	(revision 22877)
+++ subversion/bindings/swig/core.i	(working copy)
@@ -691,7 +691,7 @@

   ~apr_pool_wrapper_t() {
     apr_pool_wrapper_destroy(self);
-    free(self);
+    xfree(self);
   }
 };

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Release memory aquired with ruby_xmalloc with ruby_xfree

Posted by Joe Swatosh <jo...@gmail.com>.
Hi Daniel,

On 1/4/07, Daniel Rall <dl...@collab.net> wrote:
> Yeah, it does seem like a good idea.  Committed to trunk in r22909.
>


Thanks,
--
Joe Swatosh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Release memory aquired with ruby_xmalloc with ruby_xfree

Posted by Daniel Rall <dl...@collab.net>.
Yeah, it does seem like a good idea.  Committed to trunk in r22909.

On Tue, 02 Jan 2007, Joe Swatosh wrote:

> Hi All,
> 
> I found this when I tried to run a debug build.  Not sure how
> important it is, but it seems like a good idea.
> 
> [[[
> * subversion/bindings/swig/core.i
>  Release memory aquired with ruby_xmalloc with ruby_xfree.
> ]]]
> 
> Index: subversion/bindings/swig/core.i
> ===================================================================
> --- subversion/bindings/swig/core.i	(revision 22877)
> +++ subversion/bindings/swig/core.i	(working copy)
> @@ -691,7 +691,7 @@
> 
>   ~apr_pool_wrapper_t() {
>     apr_pool_wrapper_destroy(self);
> -    free(self);
> +    xfree(self);
>   }
> };
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org