[GitHub] [kafka] ableegoldman commented on a change in pull request #8927: KAFKA-10200: Fix testability of PAPI with windowed stores

[GitBox <gi...@apache.org>]

ableegoldman commented on a change in pull request #8927:
URL: https://github.com/apache/kafka/pull/8927#discussion_r446418844



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextUtils.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.streams.processor.internals;
+
+import org.apache.kafka.streams.processor.ProcessorContext;
+import org.apache.kafka.streams.processor.internals.metrics.StreamsMetricsImpl;
+
+public final class ProcessorContextUtils {

Review comment:
       I'm trying to phrase this is a less discouraging way, since I agree this is a nice & clever fix: 
   
   is this meant to be the actual, final solution to this problem, or just a temporary workaround to unblock us without the need for a KIP? This just "happens" to work out nicely because we know the mocks are actually returning a StreamsMetricsImpl as well. What happens if we need to add/access more complicated processor context functionality in the inner state stores? I say "inner" because the caching layers for example also perform a cast to InternalProcessorContext.
   
   I completely agree with proceeding with this, so don't take that question as a challenge to this PR. Just wondering where this leaves us going forward. Should we accept (and therefore enforce) that state stores can't have caching enabled in unit tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org