You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jono-morris (via GitHub)" <gi...@apache.org> on 2023/10/09 12:54:30 UTC
[PR] Camel 17040 add no data response option [camel]
jono-morris opened a new pull request, #11673:
URL: https://github.com/apache/camel/pull/11673
Add a new option allowing HTTP 204 to be returned with an empty body if a Message contains an empty JSON object, or XML root object.
Additional unit tests to be added to other components, e.g. camel-undertow, and a note to be added to the upgrade guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-17040 add no data response option [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11673:
URL: https://github.com/apache/camel/pull/11673#issuecomment-1756941512
The PR fails to build as there are uncommitted files. Can you add those files into the commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-17040 add no data response option [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on PR #11673:
URL: https://github.com/apache/camel/pull/11673#issuecomment-1757384885
When I build locally there's a few misc generated files in catalog and dsl. I've added them to this PR with this commit https://github.com/apache/camel/pull/11673/commits/a44e56e2b38efa228beca6737419cccb65c60b4e
This OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-17040 add no data response option [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on code in PR #11673:
URL: https://github.com/apache/camel/pull/11673#discussion_r1351994969
##########
components/camel-servlet/src/test/java/org/apache/camel/component/servlet/rest/Address.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.servlet.rest;
+
+import jakarta.xml.bind.annotation.*;
Review Comment:
Fix now. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel 17040 add no data response option [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on code in PR #11673:
URL: https://github.com/apache/camel/pull/11673#discussion_r1350319471
##########
components/camel-servlet/src/test/java/org/apache/camel/component/servlet/rest/Address.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.servlet.rest;
+
+import jakarta.xml.bind.annotation.*;
Review Comment:
Thanks for that. Will fix this and failing build tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-17040 add no data response option [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on code in PR #11673:
URL: https://github.com/apache/camel/pull/11673#discussion_r1351994969
##########
components/camel-servlet/src/test/java/org/apache/camel/component/servlet/rest/Address.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.servlet.rest;
+
+import jakarta.xml.bind.annotation.*;
Review Comment:
Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel 17040 add no data response option [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11673:
URL: https://github.com/apache/camel/pull/11673#issuecomment-1752959448
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-17040 add no data response option [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #11673:
URL: https://github.com/apache/camel/pull/11673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-17040 add no data response option [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on PR #11673:
URL: https://github.com/apache/camel/pull/11673#issuecomment-1756101152
Yes, will sort this out later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-17040 add no data response option [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on PR #11673:
URL: https://github.com/apache/camel/pull/11673#issuecomment-1757374246
rest-dsl.adoc updated see `cde3bacae5bb2ed0c5ee5673daf03febe08b4be5`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel 17040 add no data response option [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #11673:
URL: https://github.com/apache/camel/pull/11673#discussion_r1350277681
##########
components/camel-servlet/src/test/java/org/apache/camel/component/servlet/rest/Address.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.servlet.rest;
+
+import jakarta.xml.bind.annotation.*;
Review Comment:
Please don't use * import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Camel-17040 add no data response option [camel]
Posted by "jono-morris (via GitHub)" <gi...@apache.org>.
jono-morris commented on PR #11673:
URL: https://github.com/apache/camel/pull/11673#issuecomment-1757540092
I've committed the updated camel-spring.xsd file that was causing the build to fail with "uncommitted changes", https://github.com/apache/camel/pull/11673/commits/8276ef843f18805a46a224e92d29c6f22fdd18a7.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org