You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/12/27 04:56:27 UTC
[GitHub] [servicecomb-pack] chanjarster commented on a change in pull
request #624: SCB-1690 omega-transport-resttemplate does not use
RestTemplateBuilder
chanjarster commented on a change in pull request #624: SCB-1690 omega-transport-resttemplate does not use RestTemplateBuilder
URL: https://github.com/apache/servicecomb-pack/pull/624#discussion_r361581353
##########
File path: omega/omega-transport/omega-transport-resttemplate/src/main/java/org/apache/servicecomb/pack/omega/transport/resttemplate/RestTemplateConfig.java
##########
@@ -18,25 +18,22 @@
package org.apache.servicecomb.pack.omega.transport.resttemplate;
-import java.util.List;
-
+import org.apache.servicecomb.pack.omega.context.OmegaContext;
import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.web.client.RestTemplateBuilder;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
-import org.springframework.http.client.ClientHttpRequestInterceptor;
import org.springframework.web.client.RestTemplate;
-import org.apache.servicecomb.pack.omega.context.OmegaContext;
-
@Configuration
public class RestTemplateConfig {
@Bean(name = "omegaRestTemplate")
- public RestTemplate omegaRestTemplate(@Autowired(required=false) OmegaContext context) {
- RestTemplate template = new RestTemplate();
- List<ClientHttpRequestInterceptor> interceptors = template.getInterceptors();
- interceptors.add(new TransactionClientHttpRequestInterceptor(context));
- template.setInterceptors(interceptors);
- return template;
+ public RestTemplate omegaRestTemplate(@Autowired(required = false) OmegaContext context,
+ RestTemplateBuilder restTemplateBuilder) {
Review comment:
Yeah, we don't need it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services