You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Thejas Nair <th...@hortonworks.com> on 2014/03/13 10:30:19 UTC

Review Request 19181: "show grant ... on all" fails with NPE

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19181/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-6567
    https://issues.apache.org/jira/browse/HIVE-6567


Repository: hive-git


Description
-------

hive> show grant user user1 on all;
FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask. null

2014-03-06 08:52:39,238 ERROR exec.DDLTask (DDLTask.java:execute(423)) - java.lang.NullPointerException
        at org.apache.hadoop.hive.ql.exec.Utilities.getDbTableName(Utilities.java:2033)
        at org.apache.hadoop.hive.ql.exec.DDLTask.getHivePrivilegeObject(DDLTask.java:819)
        at org.apache.hadoop.hive.ql.exec.DDLTask.showGrantsV2(DDLTask.java:612)
        at org.apache.hadoop.hive.ql.exec.DDLTask.showGrants(DDLTask.java:515)
        at org.apache.hadoop.hive.ql.exec.DDLTask.execute(DDLTask.java:388)
        at org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:153)
        at org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:65)
        at org.apache.hadoop.hive.ql.Driver.launchTask(Driver.java:1456)
        at org.apache.hadoop.hive.ql.Driver.execute(Driver.java:1229)
        at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1047)
        at org.apache.hadoop.hive.ql.Driver.run(Driver.java:874)
        at org.apache.hadoop.hive.ql.Driver.run(Driver.java:864)
        at org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:268)
        at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:220)
        at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:424)
        at org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:793)
        at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:687)
        at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:626)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.hadoop.util.RunJar.main(RunJar.java:156)


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 2295b0d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 23dcbda 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java 638967e 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java 3f9fa81 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java ee7bef3 
  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java f69e41b 
  ql/src/test/queries/clientpositive/authorization_revoke_table_priv.q f91e100 
  ql/src/test/queries/clientpositive/authorization_view_sqlstd.q dddba34 
  ql/src/test/results/clientpositive/authorization_revoke_table_priv.q.out c1862c9 
  ql/src/test/results/clientpositive/authorization_view_sqlstd.q.out c0647af 

Diff: https://reviews.apache.org/r/19181/diff/


Testing
-------

Tests updated 


Thanks,

Thejas Nair

Re: Review Request 19181: "show grant ... on all" fails with NPE

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19181/#review37108
-----------------------------------------------------------


+1 after minor comment addressed.


ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/19181/#comment68426>

    Since you are adding a lot of Null checks, adding one more something like this privSubjectDesc == null ||  -- will be complete.
    
    I know it is unlikely this REF could be null.
    


- Mohammad Islam


On March 13, 2014, 9:30 a.m., Thejas Nair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19181/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 9:30 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-6567
>     https://issues.apache.org/jira/browse/HIVE-6567
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> hive> show grant user user1 on all;
> FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask. null
> 
> 2014-03-06 08:52:39,238 ERROR exec.DDLTask (DDLTask.java:execute(423)) - java.lang.NullPointerException
>         at org.apache.hadoop.hive.ql.exec.Utilities.getDbTableName(Utilities.java:2033)
>         at org.apache.hadoop.hive.ql.exec.DDLTask.getHivePrivilegeObject(DDLTask.java:819)
>         at org.apache.hadoop.hive.ql.exec.DDLTask.showGrantsV2(DDLTask.java:612)
>         at org.apache.hadoop.hive.ql.exec.DDLTask.showGrants(DDLTask.java:515)
>         at org.apache.hadoop.hive.ql.exec.DDLTask.execute(DDLTask.java:388)
>         at org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:153)
>         at org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:65)
>         at org.apache.hadoop.hive.ql.Driver.launchTask(Driver.java:1456)
>         at org.apache.hadoop.hive.ql.Driver.execute(Driver.java:1229)
>         at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1047)
>         at org.apache.hadoop.hive.ql.Driver.run(Driver.java:874)
>         at org.apache.hadoop.hive.ql.Driver.run(Driver.java:864)
>         at org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:268)
>         at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:220)
>         at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:424)
>         at org.apache.hadoop.hive.cli.CliDriver.executeDriver(CliDriver.java:793)
>         at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:687)
>         at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:626)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at org.apache.hadoop.util.RunJar.main(RunJar.java:156)
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 2295b0d 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 23dcbda 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java 638967e 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java 3f9fa81 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java ee7bef3 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java f69e41b 
>   ql/src/test/queries/clientpositive/authorization_revoke_table_priv.q f91e100 
>   ql/src/test/queries/clientpositive/authorization_view_sqlstd.q dddba34 
>   ql/src/test/results/clientpositive/authorization_revoke_table_priv.q.out c1862c9 
>   ql/src/test/results/clientpositive/authorization_view_sqlstd.q.out c0647af 
> 
> Diff: https://reviews.apache.org/r/19181/diff/
> 
> 
> Testing
> -------
> 
> Tests updated 
> 
> 
> Thanks,
> 
> Thejas Nair
> 
>