You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Sian January <si...@googlemail.com> on 2010/12/15 15:33:51 UTC
[build] Failure in org.apache.harmony.pack200.tests.PackingOptionsTest.testModificationTime
- commit fix or not?
I think the failure that the Hudson build and Ray are seeing in
pack200 is a regression introduced in r996801 (i.e. since the last
milestone). I can't reproduce it due to being in the UK where the
timezone offset is 0, but the fix should be as follows:
Index: src/main/java/org/apache/harmony/pack200/FileBands.java
===================================================================
--- src/main/java/org/apache/harmony/pack200/FileBands.java (revision 1002186)
+++ src/main/java/org/apache/harmony/pack200/FileBands.java (working copy)
@@ -22,6 +22,7 @@
import java.util.Iterator;
import java.util.List;
import java.util.Set;
+import java.util.TimeZone;
import org.apache.harmony.pack200.Archive.PackingFile;
import org.apache.harmony.pack200.Archive.SegmentUnit;
@@ -92,7 +93,7 @@
totalSize += file_size[i];
// update modification time
- modtime = (packingFile.getModtime()) / 1000L;
+ modtime = (packingFile.getModtime() +
TimeZone.getDefault().getRawOffset()) / 1000L;
file_modtime[i] = (int) (modtime - archiveModtime);
if (isLatest && latestModtime < file_modtime[i]) {
latestModtime = file_modtime[i];
Any support to commit before M16 or should we leave it until afterwards?
Thanks,
Sian
--
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Re: [build] Failure in org.apache.harmony.pack200.tests.PackingOptionsTest.testModificationTime
- commit fix or not?
Posted by Sian January <si...@googlemail.com>.
Thanks Tim.
Checked in to head in r1049575 and java6 branch in r1049579
On 15 December 2010 14:41, Tim Ellison <t....@gmail.com> wrote:
> On 15/Dec/2010 14:33, Sian January wrote:
>> I think the failure that the Hudson build and Ray are seeing in
>> pack200 is a regression introduced in r996801 (i.e. since the last
>> milestone). I can't reproduce it due to being in the UK where the
>> timezone offset is 0, but the fix should be as follows:
>>
> <snip>
>>
>> Any support to commit before M16 or should we leave it until afterwards?
>
> Since it is a regression introduced since our last milestone, I'm +1 for
> fixing it now.
>
> Regards,
> Tim
>
--
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Re: [build] Failure in org.apache.harmony.pack200.tests.PackingOptionsTest.testModificationTime
- commit fix or not?
Posted by Sian January <si...@googlemail.com>.
Thanks Alex.
Looks like the build is fixed now.
On 15 December 2010 15:11, Alex Blewitt <al...@gmail.com> wrote:
> On 15 Dec 2010, at 14:41, Tim Ellison <t....@gmail.com> wrote:
>
>> On 15/Dec/2010 14:33, Sian January wrote:
>>> I think the failure that the Hudson build and Ray are seeing in
>>> pack200 is a regression introduced in r996801 (i.e. since the last
>>> milestone). I can't reproduce it due to being in the UK where the
>>> timezone offset is 0, but the fix should be as follows:
>>>
>> <snip>
>>>
>>> Any support to commit before M16 or should we leave it until afterwards?
>>
>> Since it is a regression introduced since our last milestone, I'm +1 for
>> fixing it now.
>
> Fix looks sensible to me too.
>
> Alex
>
--
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Re: [build] Failure in org.apache.harmony.pack200.tests.PackingOptionsTest.testModificationTime - commit fix or not?
Posted by Alex Blewitt <al...@gmail.com>.
On 15 Dec 2010, at 14:41, Tim Ellison <t....@gmail.com> wrote:
> On 15/Dec/2010 14:33, Sian January wrote:
>> I think the failure that the Hudson build and Ray are seeing in
>> pack200 is a regression introduced in r996801 (i.e. since the last
>> milestone). I can't reproduce it due to being in the UK where the
>> timezone offset is 0, but the fix should be as follows:
>>
> <snip>
>>
>> Any support to commit before M16 or should we leave it until afterwards?
>
> Since it is a regression introduced since our last milestone, I'm +1 for
> fixing it now.
Fix looks sensible to me too.
Alex
Re: [build] Failure in org.apache.harmony.pack200.tests.PackingOptionsTest.testModificationTime
- commit fix or not?
Posted by Tim Ellison <t....@gmail.com>.
On 15/Dec/2010 14:33, Sian January wrote:
> I think the failure that the Hudson build and Ray are seeing in
> pack200 is a regression introduced in r996801 (i.e. since the last
> milestone). I can't reproduce it due to being in the UK where the
> timezone offset is 0, but the fix should be as follows:
>
<snip>
>
> Any support to commit before M16 or should we leave it until afterwards?
Since it is a regression introduced since our last milestone, I'm +1 for
fixing it now.
Regards,
Tim