[GitHub] [iceberg] danielcweeks commented on pull request #7128: Core: Optimize S3 layout of Datafiles by expanding first character set of the hash

["danielcweeks (via GitHub)" <gi...@apache.org>]

danielcweeks commented on PR #7128:
URL: https://github.com/apache/iceberg/pull/7128#issuecomment-1473136575

   I'm not sure this is really necessary.  While the distribution of the first character is relatively narrow, the reference you point to even states:
   
   > If we target conservative targets of 100 operations per second and 20 million stored objects per partition, a four character hex hash partition set in a bucket or sub-bucket namespace could theoretically grow to support millions of operations per second and over a trillion unique keys before we’d need a fifth character in the hash.
   
   We currently have 8 characters in the hash so without confirmation from the S3 it seems like we're already follow the recommendation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org