[jira] [Commented] (MESOS-5932) Replicated log's dependency on leveldb prevents it from being used on Windows

["Joseph Wu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688420#comment-15688420 ] 

Joseph Wu commented on MESOS-5932:
----------------------------------

{code}
commit 88c22daec2b048f35fd9b273872babe64a51dbf7
Author: Alex Clemmer <cl...@gmail.com>
Date:   Tue Nov 22 11:55:17 2016 -0800

    Windows: Disable persistent state for Windows master.
    
    Many Mesos tests use the master in some form.  Of those, relatively few
    strictly require the LevelDB-based storage for the replicated log.
    (Only tests with master failover require persistent storage.)
    
    Since we cannot currently compile LevelDB on Windows, and because
    running Mesos tests on Windows involves compiling and running the
    master, this commit will remove the direct dependency on the LevelDB
    storage for Windows builds of the master.
    
    Review: https://reviews.apache.org/r/53313/
{code}

> Replicated log's dependency on leveldb prevents it from being used on Windows
> -----------------------------------------------------------------------------
>
>                 Key: MESOS-5932
>                 URL: https://issues.apache.org/jira/browse/MESOS-5932
>             Project: Mesos
>          Issue Type: Bug
>          Components: master
>            Reporter: Alex Clemmer
>            Assignee: Alex Clemmer
>              Labels: agent, master, mesosphere
>
> The replicated log (in src/log/) depends on leveldb to store and persist data in the replicas.
> This dependency is well-contained within replica.cpp, but until it is abstracted out, it nonetheless prevents the master from being built on Windows, which in turn prevents the agent tests from being built and run on Windows.
> Preliminary investigation shows that we will probably want to split this work into 2 parts:
> * Temporarily remove the ability of the master to use the replicated log on Windows (in master/main.cpp). This should involve 1 conditional where we instantiate a `Log::Log`. This should be enough for us to light up the agent tests.
> * Add leveldb Windows support to Mesos. This involves: adding CMake files to build leveldb source, and adding Windows-specific `port_*` files that will map the platform-specific constructs of leveldb to Windows. We can take hints from leveldown and other projects, which add their own `port_*` files that suit their purposes (namely, running leveldb, in node, on Windows). NOTE: the leveldb community explicitly calls out in its documentation that it is not interested in non-POSIX changes, so it is likely that this will never be inducted into the mainline leveldb codebase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)