You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by JonHerr <gi...@git.apache.org> on 2016/02/24 20:41:45 UTC
[GitHub] cordova-plugin-media-capture pull request: fix for Cancel or back ...
GitHub user JonHerr opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/55
fix for Cancel or back button in Windows 8/10
I made a slight change based on changes from another user. When the cancel or back button is pressed the promise is completed and we get back that the param file is undefined. then the code continues to execute the function moveAsync() on the undefined object causing an error to be thrown. by checking if the file exists before we execute this command we can appropriately return an error of CAPTURE_NO_MEDIA_FILES.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JonHerr/cordova-plugin-media-capture master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/55.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #55
----
commit eaeba2db8832e465dbc4bf961e0c52b75aa1f1f9
Author: Jonathan Herr <jo...@hotmail.com>
Date: 2016-02-24T19:24:17Z
fix for Cancel or back button in Windows 8/10
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: fix for Cancel or back ...
Posted by JonHerr <gi...@git.apache.org>.
Github user JonHerr closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org