You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2020/02/28 13:40:15 UTC
[Issue 128310] New: Windows explorer crashes when opening specific
file
https://bz.apache.org/ooo/show_bug.cgi?id=128310
Issue ID: 128310
Issue Type: DEFECT
Summary: Windows explorer crashes when opening specific file
Product: General
Version: 4.1.7
Hardware: PC
OS: Windows 10
Status: UNCONFIRMED
Severity: Normal
Priority: P5 (lowest)
Component: ui
Assignee: issues@openoffice.apache.org
Reporter: jmaskalans@gmail.com
Target Milestone: ---
Created attachment 86862
--> https://bz.apache.org/ooo/attachment.cgi?id=86862&action=edit
System generated OO file
I have a system which generates .odt files. For some time they (.odt files)
worked fine, but in current Windows 10 releases when I download system
generated .odt file and try to open, Windows Explorer crashes. I try to open
these files right away from browser (Google Chrome and FF). Same happens on 3
Windows 10 machines. In one I could open this file when I run OpenOffice
separate and then Open from File menu. On other 2 machines as soon as I even
open Folder where file is located, Windows Explorer crashes.
I have found out, reading LibreOffice similar issues, that there is a
workaround. As soon as I modify OpenOffice installation and uninstall Windows
Explorer Extensions all works as expected. This is happening on v4.1.2 till
4.1.7
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
--- Comment #4 from Matthias Seidel <ms...@apache.org> ---
The crash occurs when Explorer wants to display the AOO Infotips for the file.
Removing the Windows Explorer Extension is one workaround.
Even opening the file with a double click anywhere else than on the filename in
the File Open Dialog will work.
Most likely the problem is in this code:
https://github.com/apache/openoffice/blob/trunk/main/shell/source/win32/shlxthandler/infotips/infotips.cxx
But at this point a developer must take over...
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
--- Comment #10 from Matthias Seidel <ms...@apache.org> ---
The crash occurs, when hovering with the mouse over the filename in Windows
Explorer.
At this point "infotips" should be displayed. For OpenDocument files this is
part of our ShellExtension (if installed):
https://github.com/apache/openoffice/tree/trunk/main/shell/source/win32/shlxthandler/infotips
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
--- Comment #2 from Matthias Seidel <ms...@apache.org> ---
Created attachment 86863
--> https://bz.apache.org/ooo/attachment.cgi?id=86863&action=edit
ODT opened and saved with AOO 4.1.7 on Ubuntu
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
--- Comment #7 from Matthias Seidel <ms...@apache.org> ---
I was now able to generate a Windows Crash Dump (explorer.exe):
https://home.apache.org/~mseidel/Issue%20128310/explorer.exe.3920.dmp
Hopefully someone can get useful information from it.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest|--- |4.1.9
Confirmation in| |
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1
Keywords| |needmoreinfo
--- Comment #3 from Matthias Seidel <ms...@apache.org> ---
Did some further tests and deleted the two mentioned folders from my saved
document. I even deleted "manifest.rdf" (which is also missing in your file).
Still no problems on Windows...
I think we really need more info about the system that generates the files.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS|Windows 10 |Windows, all
--- Comment #6 from Matthias Seidel <ms...@apache.org> ---
Unfortunately all I can see in Windows log files is the crash of Explorer.
Maybe Patricia can give more details once she has set up her build environment.
BTW: Confirmed on Windows 7 32-bit, so setting the issue to "Windows, all"
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|Normal |Major
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mseidel@apache.org
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest|4.1.9 |4.1.10
Confirmation in| |
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
--- Comment #1 from Matthias Seidel <ms...@apache.org> ---
Can you give more details about the system that is generating these ODT files?
Looking at the file with an archive viewer it is missing two folders:
- Thumbnails
- Configurations2
I am no expert in OpenDocument Format, but I would say this generated document
is not valid. At least it is missing the Thumbnails folder which the Windows
Shell Extension is probably looking for.
I opened your file on Ubuntu and saved it right away. With this file I have no
problems on Windows (see attachement).
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
--- Comment #8 from Juris <jm...@gmail.com> ---
(In reply to Matthias Seidel from comment #3)
> Did some further tests and deleted the two mentioned folders from my saved
> document. I even deleted "manifest.rdf" (which is also missing in your file).
>
> Still no problems on Windows...
>
> I think we really need more info about the system that generates the files.
Files are generated using JasperServer API. If some more details are needed I
can probably get them.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
damjan@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |damjan@apache.org
--- Comment #5 from damjan@apache.org ---
(In reply to Matthias Seidel from comment #4)
> The crash occurs when Explorer wants to display the AOO Infotips for the
> file.
>
> Removing the Windows Explorer Extension is one workaround.
> Even opening the file with a double click anywhere else than on the filename
> in the File Open Dialog will work.
>
> Most likely the problem is in this code:
> https://github.com/apache/openoffice/blob/trunk/main/shell/source/win32/
> shlxthandler/infotips/infotips.cxx
>
> But at this point a developer must take over...
---snip---
std::wstring formatSizeOfFile( DWORD dwSize )
{
if ( dwSize < 1000 )
{
char buffer[3];
int dFileSize = dwSize;
_itoa( dFileSize, buffer, 10 );
---snip---
If 100 <= dwSize <= 999, that's a buffer overflow, as buffer has only 3 chars,
and we need a 4th char to store the terminating '\0'.
There could be other problems I don't immediately see. Is there a way to get a
stack trace when this error happens?
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.2.0
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128310] Windows explorer crashes when opening specific file
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128310
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|needmoreinfo |crash
--- Comment #9 from Matthias Seidel <ms...@apache.org> ---
Thank you for the info!
However, even if the document wouldn't be valid (which I think is not the case)
the Extension (namely: Infotips) should not crash Explorer.
Thank you for finding that, we have to investigate further...
--
You are receiving this mail because:
You are the assignee for the issue.