You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sandeep Tata (JIRA)" <ji...@apache.org> on 2009/04/12 02:49:14 UTC

[jira] Created: (CASSANDRA-77) Need RangeFilter that filters by column name so that min <= name <= max

Need RangeFilter that filters by column name so that min <= name <= max
-----------------------------------------------------------------------

                 Key: CASSANDRA-77
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-77
             Project: Cassandra
          Issue Type: Sub-task
    Affects Versions: trunk
         Environment: all
            Reporter: Sandeep Tata
            Assignee: Sandeep Tata
             Fix For: trunk


We need a filter much like CountFilter and TimeFilter to satisfy mincolname <= colname <= maxcolname.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-77) Need RangeFilter that filters by column name so that min <= name <= max

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698656#action_12698656 ] 

Jonathan Ellis commented on CASSANDRA-77:
-----------------------------------------

Is this part of another feature?  As you know I'm a little leery of adding code that isn't used anywhere but I assume there is a reason behind this. :)

> Need RangeFilter that filters by column name so that min <= name <= max
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-77
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-77
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: rangefilter_and_tests.txt, rangefilter_and_tests_v2.txt
>
>
> We need a filter much like CountFilter and TimeFilter to satisfy mincolname <= colname <= maxcolname.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-77) Need RangeFilter that filters by column name so that min <= name <= max

Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandeep Tata updated CASSANDRA-77:
----------------------------------

    Attachment: rangefilter_and_tests.txt

> Need RangeFilter that filters by column name so that min <= name <= max
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-77
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-77
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: rangefilter_and_tests.txt
>
>
> We need a filter much like CountFilter and TimeFilter to satisfy mincolname <= colname <= maxcolname.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-77) Need RangeFilter that filters by column name so that min <= name <= max

Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698659#action_12698659 ] 

Sandeep Tata commented on CASSANDRA-77:
---------------------------------------

Yes, this is part of a bigger feature: range queries on column names :-)

Much like you'd want to support range queries on keys, range queries on columns can be useful too -- eg: get all columns between 'a' and 'c' or get all columns starting with 'f', etc.

I think Jun is working on the other pieces to support the rest of this, the RangeFilter is just an easy subtask I wanted to get out of the way.




> Need RangeFilter that filters by column name so that min <= name <= max
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-77
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-77
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: rangefilter_and_tests.txt, rangefilter_and_tests_v2.txt
>
>
> We need a filter much like CountFilter and TimeFilter to satisfy mincolname <= colname <= maxcolname.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-77) Need RangeFilter that filters by column name so that min <= name <= max

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-77:
------------------------------------

    Fix Version/s:     (was: 0.4)
                   0.3

> Need RangeFilter that filters by column name so that min <= name <= max
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-77
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-77
>             Project: Cassandra
>          Issue Type: Sub-task
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: 0.3
>
>         Attachments: rangefilter_and_tests.txt, rangefilter_and_tests_v2.txt
>
>
> We need a filter much like CountFilter and TimeFilter to satisfy mincolname <= colname <= maxcolname.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-77) Need RangeFilter that filters by column name so that min <= name <= max

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698604#action_12698604 ] 

Todd Lipcon commented on CASSANDRA-77:
--------------------------------------

- I don't know how Filters interact with the rest of the system very well, but isDone_ is currently always false. If it's a constant, you should skip the member variable. Otherwise, it should turn true somewhere.
- I'd like to see colMin_ and colMax_ declared final, since they are never mutated.
- The code implements colmin <= colname <= colmax, but the javadoc indicates colmin < colname < colmax
- @author tags are looked down upon by the ASF
- There's no Apache 2.0 license header
- In the unit test, you should use assertNull, assertNotNull, etc. from org.testng.Assert rather than Java assertions. This provides for more informative error messages.

> Need RangeFilter that filters by column name so that min <= name <= max
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-77
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-77
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: rangefilter_and_tests.txt
>
>
> We need a filter much like CountFilter and TimeFilter to satisfy mincolname <= colname <= maxcolname.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-77) Need RangeFilter that filters by column name so that min <= name <= max

Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandeep Tata updated CASSANDRA-77:
----------------------------------

    Attachment: rangefilter_and_tests_v2.txt

Thanks for the comments Todd.
>- I don't know how Filters interact with the rest of the system very well, but isDone_ is currently always false. If it's a constant, you should skip the member variable. Otherwise, it should turn true somewhere. 

isDone_ should always be false when you only specify a min and a max, you can't tell that you're done until you've processed all the ssTables. I've modified the filter to also accept a max-count argument. If provided, the filter is done once it has filtered count columns. If count is not provided initially, then the behavior is as before, the filter is not done until all ssTables are processed.

>- I'd like to see colMin_ and colMax_ declared final, since they are never mutated. 
Done.

>- The code implements colmin <= colname <= colmax, but the javadoc indicates colmin < colname < colmax 
Fixed javadoc.

>- @author tags are looked down upon by the ASF 
Deleted.

- There's no Apache 2.0 license header 
>Added

- In the unit test, you should use assertNull, assertNotNull, etc. from org.testng.Assert rather than Java assertions. This provides for more informative error messages.
>Fixed.


> Need RangeFilter that filters by column name so that min <= name <= max
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-77
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-77
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: rangefilter_and_tests.txt, rangefilter_and_tests_v2.txt
>
>
> We need a filter much like CountFilter and TimeFilter to satisfy mincolname <= colname <= maxcolname.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-77) Need RangeFilter that filters by column name so that min <= name <= max

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-77.
-------------------------------------

    Resolution: Fixed

committed

> Need RangeFilter that filters by column name so that min <= name <= max
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-77
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-77
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: rangefilter_and_tests.txt, rangefilter_and_tests_v2.txt
>
>
> We need a filter much like CountFilter and TimeFilter to satisfy mincolname <= colname <= maxcolname.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.