You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/26 12:09:32 UTC
[GitHub] [incubator-hudi] hmatu opened a new pull request #1280: [MINOR]
Remove junit-dep dependency
hmatu opened a new pull request #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280
## What is the purpose of the pull request
Remove junit-dep dependency.
## Brief change log
- *Remove junit-dep dependency.*
## Verify this pull request
This pull request is code cleanup without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
bhasudha commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578879603
@hmatu Sorry I am still trying to understand this PR. From the pom.xml you shared above - https://github.com/stefanbirkner/system-rules/blob/system-rules-1.16.0/pom.xml it does seem like junit-dep is a compile time dependency. You also mentioned that this dependency is not used anywhere and so you are adding the exclusion. Did you see any build time warning or dependency conflicts in Hudi that caused you to raised this PR? Can you please clarify?
Although this is a simple change, there might be other unused dependencies from external libraries same like this case. We havent gone after them unless the jar size is bloating or there are conflicts etc. Thats why understanding your case would help us better to determine if others also need to be checked out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] hmatu commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
hmatu commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578765026
https://github.com/stefanbirkner/system-rules/blob/system-rules-1.16.0/pom.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578600796
After tracking the git history, the `<junit-dep.version>4.10</junit-dep.version>` was introduced via PR #846 . And the dependency was used in `hudi-cli/pom.xml`. However, the dependency was removed via HUDI-159. These actions are both invoked by @vinothchandar .
Regarding the exclusion, @hmatu can you share the result of `system-rules` via `mvn dependency:tree` Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
bhasudha commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-579390641
Sounds good. Thanks for clarifications @yanghua and @hmatu . I dont have a strong opinion on the exclusion as well. Will merge this in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] hmatu commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
hmatu commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578889066
> @hmatu Sorry I am still trying to understand this PR. From the pom.xml you shared above - https://github.com/stefanbirkner/system-rules/blob/system-rules-1.16.0/pom.xml it does seem like junit-dep is a compile time dependency. You also mentioned that this dependency is not used anywhere and so you are adding the exclusion. Did you see any build time warning or dependency conflicts in Hudi that caused you to raised this PR? Can you please clarify?
> Although this is a simple change, there might be other unused dependencies from external libraries same like this case. We havent gone after them unless the jar size is bloating or there are conflicts etc. Thats why understanding your case would help us better to determine if others also need to be checked out.
Thanks. When compile the project, always need download the latest `junit-dep` version.
```
<dependency>
<groupId>junit</groupId>
<artifactId>junit-dep</artifactId>
<version>[4.9,)</version>
</dependency>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] hmatu edited a comment on issue #1280: [MINOR]
Remove junit-dep dependency
Posted by GitBox <gi...@apache.org>.
hmatu edited a comment on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578496166
No need to download `junit-dep`.
```
total 120
drwxr-xr-x 5 hmatu staff 160 Jan 26 20:11 4.10
drwxr-xr-x 5 hmatu staff 160 Jan 26 20:11 4.11-beta-1
drwxr-xr-x 6 hmatu staff 192 Jan 26 20:11 4.11.20120805.1225
drwxr-xr-x 5 hmatu staff 160 Jan 26 20:11 4.9
-rw-r--r-- 1 hmatu staff 563 Jan 26 20:11 maven-metadata-Maven Central.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-Maven Central.xml.sha1
-rw-r--r-- 1 hmatu staff 563 Jan 26 20:11 maven-metadata-central.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-central.xml.sha1
-rw-r--r-- 1 hmatu staff 733 Jan 26 20:11 maven-metadata-libs-milestone.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-libs-milestone.xml.sha1
-rw-r--r-- 1 hmatu staff 733 Jan 26 20:11 maven-metadata-libs-release.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-libs-release.xml.sha1
-rw-r--r-- 1 hmatu staff 1533 Jan 26 20:11 resolver-status.properties
```
### System-rules
[system-rules](https://github.com/stefanbirkner/system-rules)
```
<dependency>
<groupId>junit</groupId>
<artifactId>junit-dep</artifactId>
<version>[4.9,)</version>
</dependency>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] hmatu edited a comment on issue #1280: [MINOR]
Remove junit-dep dependency
Posted by GitBox <gi...@apache.org>.
hmatu edited a comment on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578496166
No need to download `junit-dep`.
```
total 120
drwxr-xr-x 5 hmatu staff 160 Jan 26 20:11 4.10
drwxr-xr-x 5 hmatu staff 160 Jan 26 20:11 4.11-beta-1
drwxr-xr-x 6 hmatu staff 192 Jan 26 20:11 4.11.20120805.1225
drwxr-xr-x 5 hmatu staff 160 Jan 26 20:11 4.9
-rw-r--r-- 1 hmatu staff 563 Jan 26 20:11 maven-metadata-Maven Central.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-Maven Central.xml.sha1
-rw-r--r-- 1 hmatu staff 563 Jan 26 20:11 maven-metadata-central.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-central.xml.sha1
-rw-r--r-- 1 hmatu staff 733 Jan 26 20:11 maven-metadata-libs-milestone.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-libs-milestone.xml.sha1
-rw-r--r-- 1 hmatu staff 733 Jan 26 20:11 maven-metadata-libs-release.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-libs-release.xml.sha1
-rw-r--r-- 1 hmatu staff 1533 Jan 26 20:11 resolver-status.properties
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578691365
> > After tracking the git history, the `<junit-dep.version>4.10</junit-dep.version>` was introduced via PR #846 . And the dependency was used in `hudi-cli/pom.xml`. Then, the dependency was removed via HUDI-159. These actions are both invoked by @vinothchandar .
> > Regarding the exclusion, @hmatu can you share the result of `system-rules` via `mvn dependency:tree`? Thanks.
>
> ```
> [INFO] \- com.github.stefanbirkner:system-rules:jar:1.16.0:test
> ```
So `system-rules` does not depend on **junit-dep**?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] hmatu commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
hmatu commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578622348
@bhasudha right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua edited a comment on issue #1280: [MINOR]
Remove junit-dep dependency
Posted by GitBox <gi...@apache.org>.
yanghua edited a comment on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578600796
After tracking the git history, the `<junit-dep.version>4.10</junit-dep.version>` was introduced via PR #846 . And the dependency was used in `hudi-cli/pom.xml`. Then, the dependency was removed via HUDI-159. These actions are both invoked by @vinothchandar .
Regarding the exclusion, @hmatu can you share the result of `system-rules` via `mvn dependency:tree`? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1280: [MINOR]
Remove junit-dep dependency
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578533522
@bhasudha can you take this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua edited a comment on issue #1280: [MINOR]
Remove junit-dep dependency
Posted by GitBox <gi...@apache.org>.
yanghua edited a comment on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578600796
After tracking the git history, the `<junit-dep.version>4.10</junit-dep.version>` was introduced via PR #846 . And the dependency was used in `hudi-cli/pom.xml`. Then, the dependency was removed via HUDI-159. These actions are both invoked by @vinothchandar .
Regarding the exclusion, @hmatu can you share the result of `system-rules` via `mvn dependency:tree` Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] hmatu edited a comment on issue #1280: [MINOR]
Remove junit-dep dependency
Posted by GitBox <gi...@apache.org>.
hmatu edited a comment on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-579099464
No, `system-rules` can be deleted as a whole, it takes longer to compile project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-579053301
> After tracking the git history, the `<junit-dep.version>4.10</junit-dep.version>` was introduced via PR #846 . And the dependency was used in `hudi-cli/pom.xml`. Then, the dependency was removed via HUDI-159. These actions are both invoked by @vinothchandar .
>
> Regarding the exclusion, @hmatu can you share the result of `system-rules` via `mvn dependency:tree`? Thanks.
@bhasudha IMO, we can accept this PR (without the added exclusion property). In the early time, Hudi clearly introduced `junit-dep` dependency, just like I mentioned before. However, the dependency has been clearly removed, so the line `<junit-dep.version>4.10</junit-dep.version>` belongs to the legacy line. We can remove it.
About the added exclusion property, we can add it or not. Although as @hmatu said, it would always be downloaded. However, it does not matter. It did not cause the version conflict.
IMO, the exclusion property is usually used to handle version conflict of the same dependency. Generally, we clearly introduce a specific-version dependency then exclude the transitive dependencies which are owned by other dependencies. If a transitive dependency is harmless, we do not need to explicitly exclude it.
In short, I agree with cleaning `<junit-dep.version>4.10</junit-dep.version>` up. As for exclusion, I am open. I recommend not including this exclusion.
WDYT? @bhasudha @hmatu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha merged pull request #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
bhasudha merged pull request #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] hmatu commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
hmatu commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578496166
No need to download `junit-dep` everytime.
```
total 120
drwxr-xr-x 5 hmatu staff 160 Jan 26 20:11 4.10
drwxr-xr-x 5 hmatu staff 160 Jan 26 20:11 4.11-beta-1
drwxr-xr-x 6 hmatu staff 192 Jan 26 20:11 4.11.20120805.1225
drwxr-xr-x 5 hmatu staff 160 Jan 26 20:11 4.9
-rw-r--r-- 1 hmatu staff 563 Jan 26 20:11 maven-metadata-Maven Central.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-Maven Central.xml.sha1
-rw-r--r-- 1 hmatu staff 563 Jan 26 20:11 maven-metadata-central.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-central.xml.sha1
-rw-r--r-- 1 hmatu staff 733 Jan 26 20:11 maven-metadata-libs-milestone.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-libs-milestone.xml.sha1
-rw-r--r-- 1 hmatu staff 733 Jan 26 20:11 maven-metadata-libs-release.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-libs-release.xml.sha1
-rw-r--r-- 1 hmatu staff 1533 Jan 26 20:11 resolver-status.properties
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua edited a comment on issue #1280: [MINOR]
Remove junit-dep dependency
Posted by GitBox <gi...@apache.org>.
yanghua edited a comment on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578691365
> > After tracking the git history, the `<junit-dep.version>4.10</junit-dep.version>` was introduced via PR #846 . And the dependency was used in `hudi-cli/pom.xml`. Then, the dependency was removed via HUDI-159. These actions are both invoked by @vinothchandar .
> > Regarding the exclusion, @hmatu can you share the result of `system-rules` via `mvn dependency:tree`? Thanks.
>
> ```
> [INFO] \- com.github.stefanbirkner:system-rules:jar:1.16.0:test
> ```
I want to see if `system-rules` really depends on **junit-dep**.
From the maven public repository, I see that it depends on **junit-dep**:https://mvnrepository.com/artifact/com.github.stefanbirkner/system-rules/1.16.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] hmatu commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
hmatu commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-579099464
No, in fact, `system-rules` can be deleted as a whole.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua edited a comment on issue #1280: [MINOR]
Remove junit-dep dependency
Posted by GitBox <gi...@apache.org>.
yanghua edited a comment on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578691365
> > After tracking the git history, the `<junit-dep.version>4.10</junit-dep.version>` was introduced via PR #846 . And the dependency was used in `hudi-cli/pom.xml`. Then, the dependency was removed via HUDI-159. These actions are both invoked by @vinothchandar .
> > Regarding the exclusion, @hmatu can you share the result of `system-rules` via `mvn dependency:tree`? Thanks.
>
> ```
> [INFO] \- com.github.stefanbirkner:system-rules:jar:1.16.0:test
> ```
I want to see if `system-rules` really contains **junit-dep** dependency. However, you did not show the dependency relationship.
From the maven public repository, I see that it depends on **junit-dep**:https://mvnrepository.com/artifact/com.github.stefanbirkner/system-rules/1.16.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] bhasudha commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
bhasudha commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578603992
@hmatu quick question. Is this a dependency that is not used anywhere and so are we removing it ? Just curious how you bumped into this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-579181041
> No, `system-rules` can be deleted as a whole, it takes longer to compile project.
If you can make sure we do not need the `system-rules`. I agree with deleting this dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua edited a comment on issue #1280: [MINOR]
Remove junit-dep dependency
Posted by GitBox <gi...@apache.org>.
yanghua edited a comment on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578691365
> > After tracking the git history, the `<junit-dep.version>4.10</junit-dep.version>` was introduced via PR #846 . And the dependency was used in `hudi-cli/pom.xml`. Then, the dependency was removed via HUDI-159. These actions are both invoked by @vinothchandar .
> > Regarding the exclusion, @hmatu can you share the result of `system-rules` via `mvn dependency:tree`? Thanks.
>
> ```
> [INFO] \- com.github.stefanbirkner:system-rules:jar:1.16.0:test
> ```
I want to see if `system-rules` really contains **junit-dep** dependency. However, you did not show the dependency relationship.
From the maven public repository, I see that it contains **junit-dep** dependency :https://mvnrepository.com/artifact/com.github.stefanbirkner/system-rules/1.16.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] hmatu commented on issue #1280: [MINOR] Remove
junit-dep dependency
Posted by GitBox <gi...@apache.org>.
hmatu commented on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578601788
> After tracking the git history, the `<junit-dep.version>4.10</junit-dep.version>` was introduced via PR #846 . And the dependency was used in `hudi-cli/pom.xml`. Then, the dependency was removed via HUDI-159. These actions are both invoked by @vinothchandar .
>
> Regarding the exclusion, @hmatu can you share the result of `system-rules` via `mvn dependency:tree`? Thanks.
```
[INFO] \- com.github.stefanbirkner:system-rules:jar:1.16.0:test
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] hmatu removed a comment on issue #1280: [MINOR]
Remove junit-dep dependency
Posted by GitBox <gi...@apache.org>.
hmatu removed a comment on issue #1280: [MINOR] Remove junit-dep dependency
URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578496166
No need to download `junit-dep`.
```
total 120
drwxr-xr-x 5 hmatu staff 160 Jan 26 20:11 4.10
drwxr-xr-x 5 hmatu staff 160 Jan 26 20:11 4.11-beta-1
drwxr-xr-x 6 hmatu staff 192 Jan 26 20:11 4.11.20120805.1225
drwxr-xr-x 5 hmatu staff 160 Jan 26 20:11 4.9
-rw-r--r-- 1 hmatu staff 563 Jan 26 20:11 maven-metadata-Maven Central.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-Maven Central.xml.sha1
-rw-r--r-- 1 hmatu staff 563 Jan 26 20:11 maven-metadata-central.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-central.xml.sha1
-rw-r--r-- 1 hmatu staff 733 Jan 26 20:11 maven-metadata-libs-milestone.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-libs-milestone.xml.sha1
-rw-r--r-- 1 hmatu staff 733 Jan 26 20:11 maven-metadata-libs-release.xml
-rw-r--r-- 1 hmatu staff 40 Jan 26 20:11 maven-metadata-libs-release.xml.sha1
-rw-r--r-- 1 hmatu staff 1533 Jan 26 20:11 resolver-status.properties
```
### System-rules
[system-rules](https://github.com/stefanbirkner/system-rules)
```
<dependency>
<groupId>junit</groupId>
<artifactId>junit-dep</artifactId>
<version>[4.9,)</version>
</dependency>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services